Skip to content

feat(spannertest): Add validation of duplicated column names#4611

Merged
olavloite merged 3 commits intogoogleapis:masterfrom
sryoya:add_validation_for_duplicated_columns
Aug 16, 2021
Merged

feat(spannertest): Add validation of duplicated column names#4611
olavloite merged 3 commits intogoogleapis:masterfrom
sryoya:add_validation_for_duplicated_columns

Conversation

@sryoya
Copy link
Copy Markdown
Contributor

@sryoya sryoya commented Aug 13, 2021

Fixes #4610

@sryoya sryoya requested a review from a team August 13, 2021 15:00
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2021
@sryoya sryoya changed the title feat(spannertest): add validation for duplicated column names feat(spannertest): Add validation of duplicated column names Aug 13, 2021
@hengfengli hengfengli requested a review from olavloite August 14, 2021 14:36
Comment thread spanner/spannertest/db.go Outdated
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
@sryoya sryoya requested a review from olavloite August 16, 2021 08:00
Copy link
Copy Markdown
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2021
@olavloite olavloite merged commit 84f86a6 into googleapis:master Aug 16, 2021
@sryoya sryoya deleted the add_validation_for_duplicated_columns branch August 16, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spannertest: Add validation of the duplicate column names

4 participants