tests: add patch, put, int64, cap.letter tests #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
noahdietz
reviewed
Aug 17, 2021
review suggestions Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
noahdietz
reviewed
Aug 18, 2021
noahdietz
reviewed
Aug 18, 2021
go.mod
Outdated
| @@ -10,6 +10,7 @@ require ( | |||
| github.com/googleapis/gax-go/v2 v2.0.5 | |||
| go.opencensus.io v0.23.0 | |||
| golang.org/x/oauth2 v0.0.0-20210805134026-6f1e6394065a | |||
| golang.org/x/tools v0.1.5 // indirect | |||
There was a problem hiding this comment.
Please revert this change. It was because of the go get I asked you to run.
noahdietz
reviewed
Aug 18, 2021
go.sum
Outdated
| @@ -212,6 +212,7 @@ golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= | |||
| golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= | |||
| golang.org/x/mod v0.4.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= | |||
| golang.org/x/mod v0.4.1/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= | |||
| golang.org/x/mod v0.4.2 h1:Gz96sIWK3OalVv/I/qNygP42zyoKp3xptRVCWRFEBvo= | |||
There was a problem hiding this comment.
Please revert these changes. It was because of the go get I asked you to run.
noahdietz
reviewed
Aug 18, 2021
| } | ||
| }() | ||
|
|
||
| fetched, err := c.Get(ctx, |
There was a problem hiding this comment.
check the error here after this.
noahdietz
reviewed
Aug 18, 2021
noahdietz
approved these changes
Aug 18, 2021
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests for:
1)int 64 field - b/190201970
2)a field that starts with cap letter - b/184008102
3) put, patch