feat(compute/metadata): retry error when talking to metadata service#4648
Merged
codyoss merged 5 commits intogoogleapis:masterfrom Aug 19, 2021
codyoss:metadata-retry
Merged
feat(compute/metadata): retry error when talking to metadata service#4648codyoss merged 5 commits intogoogleapis:masterfrom codyoss:metadata-retry
codyoss merged 5 commits intogoogleapis:masterfrom
codyoss:metadata-retry
Conversation
This was reported internally to be causing issues. This package is used by some of our auth flows so it should be good to make this package more resilient to transient failures. Implmentation inspired by what we do for some of our http based services. Because this package is currently not context aware I needed to add attempts so retrying does not happen forever. Five attempts was arbitrarily chosen. Fixes: #4642
product-auto-label
Bot
added
the
api: compute
google-cla
Bot
added
the
cla: yes
codyoss
added
do not merge
google-cla
Bot
added
the
cla: yes
Member
Author
|
Temporarily adding don't merge while I deploy and test this code on the platform. |
noahdietz
reviewed
Aug 19, 2021
codyoss
removed
the
do not merge
Member
Author
|
everything seems to be in working order, tested on the platform. |
noahdietz
approved these changes
Aug 19, 2021
tbpg
suggested changes
Aug 19, 2021
tbpg
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reported internally to be causing issues. This package is
used by some of our auth flows so it should be good to make this
package more resilient to transient failures. Implementation inspired
by what we do for some of our http based services.
Because this package is currently not context aware I needed to add
attempts so retrying does not happen forever. Five attempts was
arbitrarily chosen.
Fixes: #4642
Release-As: 0.94.0