fix(compute/metadata): fix retry logic to not panic on error#4714
Merged
gcf-merge-on-green[bot] merged 11 commits intogoogleapis:masterfrom Sep 2, 2021
codyoss:fix-meta-retry
Merged
fix(compute/metadata): fix retry logic to not panic on error#4714gcf-merge-on-green[bot] merged 11 commits intogoogleapis:masterfrom codyoss:fix-meta-retry
gcf-merge-on-green[bot] merged 11 commits intogoogleapis:masterfrom
codyoss:fix-meta-retry
Conversation
In the case of an error res will be nil. Fixes: #4713
product-auto-label
bot
added
the
api: compute
google-cla
bot
added
the
cla: yes
noahdietz
approved these changes
Sep 1, 2021
tbpg
approved these changes
Sep 1, 2021
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of an error res will be nil. Also, we should not break on nil err
as it might be eligible for a retry from the status code.
Fixes: #4713