Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(compute): add headers test #4933

Merged
merged 4 commits into from Oct 1, 2021
Merged

Conversation

georgiyekkert
Copy link
Contributor

This test is a requirement by vchudnov

@georgiyekkert georgiyekkert requested a review from a team as a code owner September 30, 2021 23:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing

compute/apiv1/smoke_test.go Outdated Show resolved Hide resolved
@codyoss codyoss changed the title tests: add headers test.(compute) test(compute): add headers test.(compute) Oct 1, 2021
@codyoss codyoss changed the title test(compute): add headers test.(compute) test(compute): add headers test Oct 1, 2021
@noahdietz noahdietz requested a review from codyoss October 1, 2021 18:18
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noahdietz noahdietz merged commit 43a566f into googleapis:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants