Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): reenable grpc integration tests #5027

Merged
merged 3 commits into from
Oct 26, 2021
Merged

chore(storage): reenable grpc integration tests #5027

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04d8e65
chore(storage): reenable grpc integration tests
noahdietz Oct 25, 2021
6c49003
Merge branch 'master' into enable-grpc-integration-tests
noahdietz Oct 26, 2021
63cf85c
Merge branch 'master' into enable-grpc-integration-tests
noahdietz Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions storage/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,6 @@ func TestIntegration_ObjectsRangeReader(t *testing.T) {
}

func TestIntegration_ObjectReadGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to upload test data and a gRPC client to test with.
Expand Down Expand Up @@ -839,7 +838,6 @@ func TestIntegration_ObjectReadGRPC(t *testing.T) {
}

func TestIntegration_ObjectReadChunksGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to upload test data and a gRPC client to test with.
Expand Down Expand Up @@ -904,7 +902,6 @@ func TestIntegration_ObjectReadChunksGRPC(t *testing.T) {
}

func TestIntegration_ObjectReadRelativeToEndGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to upload test data and a gRPC client to test with.
Expand Down Expand Up @@ -968,7 +965,6 @@ func TestIntegration_ObjectReadRelativeToEndGRPC(t *testing.T) {
}

func TestIntegration_ObjectReadPartialContentGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to upload test data and a gRPC client to test with.
Expand Down Expand Up @@ -1022,7 +1018,6 @@ func TestIntegration_ObjectReadPartialContentGRPC(t *testing.T) {
}

func TestIntegration_ConditionalDownloadGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to upload test data and a gRPC client to test with.
Expand Down Expand Up @@ -1059,7 +1054,6 @@ func TestIntegration_ConditionalDownloadGRPC(t *testing.T) {
}

func TestIntegration_SimpleWriteGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to read test data and a gRPC client to test write
Expand Down Expand Up @@ -1118,7 +1112,6 @@ func TestIntegration_SimpleWriteGRPC(t *testing.T) {
}

func TestIntegration_CancelWriteGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to verify test and a gRPC client to test writing.
Expand Down Expand Up @@ -1168,7 +1161,6 @@ func TestIntegration_CancelWriteGRPC(t *testing.T) {
}

func TestIntegration_MultiMessageWriteGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to read test data and a gRPC client to test write
Expand Down Expand Up @@ -1229,7 +1221,6 @@ func TestIntegration_MultiMessageWriteGRPC(t *testing.T) {
}

func TestIntegration_MultiChunkWriteGRPC(t *testing.T) {
t.Skip("https://github.com/googleapis/google-cloud-go/issues/4963")
ctx := context.Background()

// Create an HTTP client to read test data and a gRPC client to test write
Expand Down