Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pubsub): add instructions for stream management #6129

Merged
merged 4 commits into from
Jun 7, 2022
Merged

docs(pubsub): add instructions for stream management #6129

merged 4 commits into from
Jun 7, 2022

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jun 6, 2022

Fixes #5677

@hongalex hongalex requested review from a team as code owners June 6, 2022 19:24
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the Pub/Sub API. labels Jun 6, 2022
@hongalex hongalex enabled auto-merge (squash) June 7, 2022 18:23
@hongalex hongalex merged commit 01ae33a into googleapis:main Jun 7, 2022
@hongalex hongalex deleted the docs-pubsub-streams branch June 7, 2022 19:01
@maroux
Copy link

maroux commented Jul 29, 2022 •
edited
Loading

Is the documentation correct in saying GOMAXPROCS/NumCPU. I'm thinking that was meant as GOMAXPROCS _or_ NumCPU, but I read it as GOMAXPROCS divided by NumCPU which didn't track reality. Additionally, the actual code seems to be doing a max(4, GOMAXPROCS) so is the documentation just wrong, or did I miss something?

@hongalex
Copy link
Member Author

Yeah it's meant to be an OR, sorry that's not very clear I'll update that. And yes, max(4, GOMAXPROCS) is correct.

@maroux
Copy link

maroux commented Jul 29, 2022

Actually, wait, that code says min(4, GOMAXPROCS).

@hongalex
Copy link
Member Author

You're right. Thanks for bringing it up! I'll get this addressed in the same PR

@hongalex hongalex mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: improve documentation with large number of streams
3 participants
@hongalex @maroux @feywind