Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix regen #6136

Merged
merged 1 commit into from
Jun 7, 2022
Merged

chore: fix regen #6136

merged 1 commit into from
Jun 7, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jun 7, 2022

An upcomming change removes some files from tracking. Our current
regen tries to always retain removed files. This is causing issues
in our pipeline so I manually removed the generated surfaces that
are going away in the linked commit:
googleapis/googleapis@7837470

An upcomming change removes some files from tracking. Our current
regen tries to always retain removed files. This is causing issues
in our pipeline so I manually removed the generated surfaces that
are going away in the linked commit:
googleapis/googleapis@7837470
@codyoss codyoss requested a review from a team as a code owner June 7, 2022 21:26
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jun 7, 2022
@codyoss codyoss enabled auto-merge (squash) June 7, 2022 21:26
@codyoss
Copy link
Member Author

codyoss commented Jun 7, 2022

Did a local go mod replace with sister PR and everything built with the changes being made to genproto after these files were removed

@codyoss codyoss merged commit c05a06b into googleapis:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants