Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): support exactly once delivery #6506

Merged
merged 31 commits into from
Aug 22, 2022

Commits on May 17, 2022

  1. feat(pubsub): prepare iterator for exactly once (googleapis#6040)

    * feat(pubsub): read exactly once for SubscriptionProperties
    
    * rename vars to be specific this is exactly once delivery
    hongalex committed May 17, 2022
    Configuration menu
    Copy the full SHA
    bba894a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. resolve merge conflict

    hongalex committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    4abfa9b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Merge branch 'main' of ssh://github.com/googleapis/google-cloud-go in…

    …to pubsub-exactly-once
    hongalex committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    e0c7032 View commit details
    Browse the repository at this point in the history
  2. feat(pubsub): send stream ack deadline seconds on exactly once change g…

    …oogleapis#6157 (googleapis#6162)
    
    * add RWMutex for guarding exactly once bool
    
    * feat(pubsub): send stream ack deadline seconds on exactly once change
    
    * remove extra test
    hongalex committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    cef6e01 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. feat(pubsub): add AckWithResult and NackWithResult to message (google…

    …apis#6201)
    
    * add AckResult and related methods
    
    * feat(pubsub): add AckWithResult and NackWithResult to message
    
    * feat(pubsub): add AckWithResult and NackWithResult to message
    
    * add comments for AckResult and bring over AcknowledgeStatus from internal
    
    * update function definition for IgnoreExported in tests
    
    * temporarily update internal/pubsub for samples test
    
    * change enum naming to AcknowledgeStatus
    
    * remove extra enums in temp internal message.go
    
    * remove internal/pubsub/message.go
    
    * fix style issues with variadic function options
    
    * add back comment format to exported const
    
    * keep track of AckResults if exactly once is enabled
    hongalex committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c636f5f View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. feat(pubsub): add helper method for parsing ErrorInfos (googleapis#6281)

    * add AckResult and related methods
    
    * feat(pubsub): add AckWithResult and NackWithResult to message
    
    * feat(pubsub): add AckWithResult and NackWithResult to message
    
    * add comments for AckResult and bring over AcknowledgeStatus from internal
    
    * update function definition for IgnoreExported in tests
    
    * temporarily update internal/pubsub for samples test
    
    * add process results
    
    * change enum naming to AcknowledgeStatus
    
    * remove extra enums in temp internal message.go
    
    * remove internal/pubsub/message.go
    
    * add process results
    
    * update process info with new enum names
    
    * add tests to process error info
    
    * add process results
    
    * update process info with new enum names
    
    * add process results
    
    * add tests to process error info
    
    * clean up iterator from merge
    
    * cleanup comments
    
    * add list of retriable errors to test
    
    * simplify testing of completed/retry slice lengths
    
    * remove getStatus/ackErrors methods
    
    * address code review comments
    
    * remove error string conversion step
    hongalex committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    aa6da2e View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. feat(pubsub): complete AckResult for exactly once (googleapis#6387)

    * refactor sendAck to pipe errors to AckResult map
    
    * rewrite sendAck/sendModAck for exactly once
    
    * add AckResult to list of uncompared methods
    
    * use ackResultWithID in all locations
    hongalex committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c2de57c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. resolve merge with main

    hongalex committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    6eb2c9c View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Merge branch 'main' of ssh://github.com/googleapis/google-cloud-go in…

    …to pubsub-exactly-once
    hongalex committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    137bc7d View commit details
    Browse the repository at this point in the history
  2. feat(pubsub): retry temporary failures for ack/modacks (googleapis#6485)

    * retry acks in goroutine
    
    * retry acks/modacks with transient errors
    
    * add retry test
    
    * add nack tests and support shorter timeouts
    
    * add integration tests
    
    * remove extra comment
    
    * add commnets to ack/modack methods in iterator
    hongalex committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    4b80b1f View commit details
    Browse the repository at this point in the history
  3. Merge branch 'pubsub-exactly-once' of ssh://github.com/googleapis/goo…

    …gle-cloud-go into pubsub-exactly-once
    hongalex committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ee0bd5e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eedb852 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Configuration menu
    Copy the full SHA
    18aaabf View commit details
    Browse the repository at this point in the history
  2. reduce number of mutex locks

    hongalex committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    346d154 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'pubsub-exactly-once' of github.com:hongalex/google-clou…

    …d-go into pubsub-exactly-once
    hongalex committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c30568b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c1e50f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. Configuration menu
    Copy the full SHA
    e729543 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'pubsub-exactly-once' of github.com:hongalex/google-clou…

    …d-go into pubsub-exactly-once
    hongalex committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    c81c266 View commit details
    Browse the repository at this point in the history
  3. fix lint issues

    hongalex committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    b637e09 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f474b62 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a8feee0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    550c484 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Configuration menu
    Copy the full SHA
    f2302aa View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Configuration menu
    Copy the full SHA
    611e88a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Configuration menu
    Copy the full SHA
    27590cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df69166 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'pubsub-exactly-once' of github.com:hongalex/google-clou…

    …d-go into pubsub-exactly-once
    hongalex committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    04b9b16 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Configuration menu
    Copy the full SHA
    0230bd5 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Configuration menu
    Copy the full SHA
    25131f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad04389 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Configuration menu
    Copy the full SHA
    71c20a7 View commit details
    Browse the repository at this point in the history