feat(pubsub): send stream ack deadline seconds on exactly once change #6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(storage): implement ListObjectACLs * update comments * update comments
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#820 Changes: feat(talent): add methods for Long Running Operations service PiperOrigin-RevId: 452382366 Source-Link: googleapis/googleapis@c19c963 chore(gkebackup): Configuration for Ruby gkebackup clients PiperOrigin-RevId: 452310108 Source-Link: googleapis/googleapis@38a6540 docs(datastore/admin): clarifications for `DatastoreFirestoreMigraitonMetadata` feat: new enum value `OPTIMISTIC_WITH_ENTITY_GROUPS` for `ConcurrencyMode` PiperOrigin-RevId: 452220654 Source-Link: googleapis/googleapis@454ad5e
* docs(pubsub): add instructions for stream management * fix comment formatting
An upcomming change removes some files from tracking. Our current regen tries to always retain removed files. This is causing issues in our pipeline so I manually removed the generated surfaces that are going away in the linked commit: googleapis/googleapis@7837470
…googleapis#5812) Adds a new LifecycleAction value. Fixes googleapis#5795 Co-authored-by: Sameena Shaffeeullah <samazisha@gmail.com> Co-authored-by: Chris Cotter <cjcotter@google.com>
Co-authored-by: Chris Cotter <cjcotter@google.com>
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#823 Changes: chore(shell): add http rules for LROs PiperOrigin-RevId: 453261273 Source-Link: googleapis/googleapis@f8e97f9 fix(talent)!: remove Application and Profile services and and related protos, enums, and messages PiperOrigin-RevId: 453241222 Source-Link: googleapis/googleapis@7837470 feat(functions): added support for CMEK docs: clarified wording around quota usage Clients can now specify the docker registry to use for storing function Docker images and KMS crypto keys for function source code objects. PiperOrigin-RevId: 453234231 Source-Link: googleapis/googleapis@d180952 feat(aiplatform): add monitor_window to ModelDeploymentMonitoringScheduleConfig proto in aiplatform v1/v1beta1 model_deployment_monitoring_job.proto PiperOrigin-RevId: 453226330 Source-Link: googleapis/googleapis@239db5e docs(contactcenterinsights): Updating comments PiperOrigin-RevId: 452751522 Source-Link: googleapis/googleapis@530ca55 feat(gkehub): Added support for locations and iam_policy clients PiperOrigin-RevId: 452647783 Source-Link: googleapis/googleapis@fbb5dd9 feat(spanner): add Session creator role docs: clarify transaction semantics PiperOrigin-RevId: 452634948 Source-Link: googleapis/googleapis@df51ec8 feat(compute): Update Compute Engine API to revision 20220526 (googleapis#722) Source-Link: googleapis/googleapis@950dd73
product-auto-label
bot
added
size: m
…to stream-ack-deadline
product-auto-label
bot
added
size: xl
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
hongalex
added a commit
that referenced
this pull request
Aug 22, 2022
* feat(pubsub): prepare iterator for exactly once (#6040) * feat(pubsub): read exactly once for SubscriptionProperties * rename vars to be specific this is exactly once delivery * feat(pubsub): send stream ack deadline seconds on exactly once change #6157 (#6162) * add RWMutex for guarding exactly once bool * feat(pubsub): send stream ack deadline seconds on exactly once change * remove extra test * feat(pubsub): add AckWithResult and NackWithResult to message (#6201) * add AckResult and related methods * feat(pubsub): add AckWithResult and NackWithResult to message * feat(pubsub): add AckWithResult and NackWithResult to message * add comments for AckResult and bring over AcknowledgeStatus from internal * update function definition for IgnoreExported in tests * temporarily update internal/pubsub for samples test * change enum naming to AcknowledgeStatus * remove extra enums in temp internal message.go * remove internal/pubsub/message.go * fix style issues with variadic function options * add back comment format to exported const * keep track of AckResults if exactly once is enabled * feat(pubsub): add helper method for parsing ErrorInfos (#6281) * add AckResult and related methods * feat(pubsub): add AckWithResult and NackWithResult to message * feat(pubsub): add AckWithResult and NackWithResult to message * add comments for AckResult and bring over AcknowledgeStatus from internal * update function definition for IgnoreExported in tests * temporarily update internal/pubsub for samples test * add process results * change enum naming to AcknowledgeStatus * remove extra enums in temp internal message.go * remove internal/pubsub/message.go * add process results * update process info with new enum names * add tests to process error info * add process results * update process info with new enum names * add process results * add tests to process error info * clean up iterator from merge * cleanup comments * add list of retriable errors to test * simplify testing of completed/retry slice lengths * remove getStatus/ackErrors methods * address code review comments * remove error string conversion step * feat(pubsub): complete AckResult for exactly once (#6387) * refactor sendAck to pipe errors to AckResult map * rewrite sendAck/sendModAck for exactly once * add AckResult to list of uncompared methods * use ackResultWithID in all locations * feat(pubsub): retry temporary failures for ack/modacks (#6485) * retry acks in goroutine * retry acks/modacks with transient errors * add retry test * add nack tests and support shorter timeouts * add integration tests * remove extra comment * add commnets to ack/modack methods in iterator * remove transient invalid ack id error string * reduce number of mutex locks * pass in StreamAckDeadline seconds for streaming pull requests in fake_test * fix lint issues * add changes to internal/pubsub/message * implement default ack handler functions in lite * use pubsub package ack result * use pinned library for pubsublite * resolve all lite Ack/NackWithResult to success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.