-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(internal/generated/snippets): remove orphaned snippets #6541
Conversation
quartzmo
commented
Aug 18, 2022
•
edited
Loading
edited
- upgrade dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but most if not all of these should have replace directives that override what code is actually being run. This is how we can have samples for unreleased code.
Right, my main objective with this PR is to see if the kokoro build errors we saw yesterday in #6523 occur in a new branch off main. |
Even though the build passes, I still see the errors below in the kokoro latest log: @codyoss Does this suggest that there are orphaned snippet files (such as
|
@quartzmo Yeah lets just get those cleaned up here to. From prior breaking changes that have removed things. snipetgen is only additive today, it will not remove orphaned snippets. This may be a good enhancement for the future. |
/cc @noahdietz
|
94e33ae
to
ba88a87
Compare