Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): implement gRPC ListObjects read_mask support #6808

Merged
merged 11 commits into from Oct 11, 2022
Merged

chore(storage): implement gRPC ListObjects read_mask support #6808

merged 11 commits into from Oct 11, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Oct 4, 2022 •
edited

This adds Query-to-FieldMask conversion for Object attributes and incorporates that into ListObjects for gRPC.

This also carves out the ListObjects-specific tests from TestIntegration_Objects and enables those tests for multi-transport testing.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the Cloud Storage API. labels Oct 4, 2022
noahdietz
noahdietz commented Oct 4, 2022
View reviewed changes
storage/integration_test.go Outdated Show resolved Hide resolved
@noahdietz noahdietz marked this pull request as ready for review October 4, 2022 17:01
@noahdietz noahdietz requested review from a team as code owners October 4, 2022 17:01
@noahdietz noahdietz requested a review from tritone October 4, 2022 17:01
tritone
tritone reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this!

storage/grpc_client.go Show resolved Hide resolved
storage/integration_test.go Outdated Show resolved Hide resolved
storage/storage.go Outdated Show resolved Hide resolved
storage/storage.go Show resolved Hide resolved
@noahdietz noahdietz requested a review from tritone October 5, 2022 18:37
tritone
tritone approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Noah!

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1d0116a into googleapis:main Oct 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noahdietz @tritone