Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): upgrade arrow to v12 to fix build error #7870

Merged
merged 3 commits into from May 4, 2023
Merged

fix(bigquery): upgrade arrow to v12 to fix build error #7870

merged 3 commits into from May 4, 2023

Conversation

dougnukem
Copy link
Contributor

Fixes: #7868

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the BigQuery API. labels May 2, 2023
noahdietz
noahdietz reviewed May 2, 2023
View reviewed changes
bigquery/go.mod Outdated Show resolved Hide resolved
@noahdietz noahdietz mentioned this pull request May 2, 2023
Closed
@dougnukem dougnukem marked this pull request as ready for review May 2, 2023 18:12
@dougnukem dougnukem requested review from a team as code owners May 2, 2023 18:12
@dougnukem dougnukem requested a review from obada-ab May 2, 2023 18:12
@dougnukem dougnukem force-pushed the doug/7868-arrow-v11-build-error branch from 8f2f690 to 132174b Compare May 2, 2023 18:13
noahdietz
noahdietz reviewed May 2, 2023
View reviewed changes
go.work.sum Show resolved Hide resolved
@dougnukem dougnukem force-pushed the doug/7868-arrow-v11-build-error branch from 132174b to ff32081 Compare May 2, 2023 22:53
@noahdietz noahdietz requested a review from shollyman May 3, 2023 20:49
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2023
shollyman
shollyman approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this. Confirmed I get the same sums when I make the same change locally.

@shollyman shollyman removed the request for review from obada-ab May 4, 2023 03:46
@shollyman shollyman added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 4, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2023
@shollyman
Copy link
Contributor

@noahdietz Looks like you need to approve as well as the go.work.sum file is outside my codeowners scope.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2023
@noahdietz noahdietz merged commit 402e365 into googleapis:main May 4, 2023
8 checks passed
@release-please release-please bot mentioned this pull request May 4, 2023
Merged
This was referenced May 9, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request May 9, 2023
Closed
@dougnukem dougnukem deleted the doug/7868-arrow-v11-build-error branch May 13, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz left review comments

@shollyman shollyman shollyman approved these changes

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery: failed to build github.com/apache/arrow/go/v11/internal/utils undefined: TransposeInt8Int8
5 participants
@dougnukem @shollyman @codyoss @noahdietz @kokoro-team