feat(profiler): support configurable debug logging destination #8104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
codyoss
approved these changes
Jun 15, 2023
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.0](https://togithub.com/googleapis/google-cloud-go/compare/profiler/v0.3.1...profiler/v0.4.0) (2023-10-18) ### Features * **profiler:** Support configurable debug logging destination ([#8104](https://togithub.com/googleapis/google-cloud-go/issues/8104)) ([fc3d840](https://togithub.com/googleapis/google-cloud-go/commit/fc3d84058b8932152408bc3ee0a5584dfe0b0c19)) * **profiler:** Update all direct dependencies ([b340d03](https://togithub.com/googleapis/google-cloud-go/commit/b340d030f2b52a4ce48846ce63984b28583abde6)) ### Bug Fixes * **profiler:** Migrate to protobuf-go v2 ([#8730](https://togithub.com/googleapis/google-cloud-go/issues/8730)) ([deeb583](https://togithub.com/googleapis/google-cloud-go/commit/deeb58308cbbb033e46d478b4dc8766c6689e71e)), refs [#8585](https://togithub.com/googleapis/google-cloud-go/issues/8585) * **profiler:** REST query UpdateMask bug ([df52820](https://togithub.com/googleapis/google-cloud-go/commit/df52820b0e7721954809a8aa8700b93c5662dc9b)) * **profiler:** Update golang.org/x/net to v0.17.0 ([174da47](https://togithub.com/googleapis/google-cloud-go/commit/174da47254fefb12921bbfc65b7829a453af6f5d)) * **profiler:** Update grpc to v1.55.0 ([1147ce0](https://togithub.com/googleapis/google-cloud-go/commit/1147ce02a990276ca4f8ab7a1ab65c14da4450ef)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure the destination of debug logs coming from a profiler. The default is
os.Stderr.Incorporates it into an existing test to make sure the routing works.
Fixes #8089