Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): automatic project detection in logging.NewClient() #9006

Merged
merged 4 commits into from Dec 6, 2023
Merged

feat(logging): automatic project detection in logging.NewClient() #9006

merged 4 commits into from Dec 6, 2023

Conversation

gkevinzheng
Copy link
Contributor

Use detectResource in resource.go to automatically detect the project in logging.NewClient if an empty string is passed in as a parent.

Fixes #7321

@gkevinzheng gkevinzheng requested review from a team as code owners November 14, 2023 19:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the Cloud Logging API. labels Nov 14, 2023
bhshkh
bhshkh requested changes Nov 30, 2023
View reviewed changes
logging/logging.go Outdated Show resolved Hide resolved
@gkevinzheng gkevinzheng enabled auto-merge (squash) December 6, 2023 21:47
@gkevinzheng gkevinzheng merged commit bc13e6a into googleapis:main Dec 6, 2023
9 checks passed
@release-please release-please bot mentioned this pull request Dec 6, 2023
Merged
@gkevinzheng gkevinzheng deleted the logging-new-client-parent branch December 11, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@bhshkh bhshkh bhshkh approved these changes

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging: automatic project detection in logging.NewClient()
3 participants
@gkevinzheng @noahdietz @bhshkh