Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vertexai): bump deps to fix build error #9168

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix(vertexai): bump deps to fix build error #9168

merged 1 commit into from
Dec 14, 2023

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 14, 2023 •
edited

Tested locally to make sure it works.

Fixes: #9167

@codyoss codyoss requested review from a team as code owners December 14, 2023 01:34
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 14, 2023
@codyoss
Copy link
Member Author

codyoss commented Dec 14, 2023

As a side note to @eliben @jba I don't understand why go build did not catch this... Does it have to do with the module workspace or am I missing something?

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit d361c59 into googleapis:main Dec 14, 2023
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2023
@codyoss codyoss deleted the vertex-fix branch December 14, 2023 01:44
@release-please release-please bot mentioned this pull request Dec 14, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 14, 2023
@release-please
chore(main): release vertexai 0.5.2 (#9169)
b794750 
🤖 I have created a release *beep* *boop*
---


## [0.5.2](https://togithub.com/googleapis/google-cloud-go/compare/vertexai/v0.5.1...vertexai/v0.5.2) (2023-12-14)


### Bug Fixes

* **vertexai:** Bump deps to fix build error ([#9168](https://togithub.com/googleapis/google-cloud-go/issues/9168)) ([d361c59](https://togithub.com/googleapis/google-cloud-go/commit/d361c59953ec815bc3fbd0fdba04069c68e5cd99)), refs [#9167](https://togithub.com/googleapis/google-cloud-go/issues/9167)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@eliben
Copy link
Contributor

eliben commented Dec 14, 2023

As a side note to @eliben @jba I don't understand why go build did not catch this... Does it have to do with the module workspace or am I missing something?

The root repo has a go.work file, which will mask such issues. This is the reason why having a go.work file committed is considered dangerous; when it's committed, it's worth at least running the tests with GOWORK=off to catch such issues.

You can try to run all tests in this repo with GOWORK=off in CI - this may uncover surprises :)

@codyoss
Copy link
Member Author

codyoss commented Dec 14, 2023

This is the reason why having a go.work file committed is considered dangerous

I never got this impression when reading docs. Is this written anywhere?

You can try to run all tests in this repo with GOWORK=off

Will file an issue, thanks

@codyoss codyoss mentioned this pull request Dec 14, 2023
Closed
@eliben
Copy link
Contributor

eliben commented Dec 14, 2023

This is the reason why having a go.work file committed is considered dangerous

I never got this impression when reading docs. Is this written anywhere?

I'll reply in #9170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
3 participants
@codyoss @eliben @noahdietz