Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aiplatform): Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData #9247

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 12, 2024

  • Regenerate this pull request now.

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
feat: add CountTokens method to llm_utility_service
docs: minor changes to comments

PiperOrigin-RevId: 597667108

Source-Link: googleapis/googleapis@714ab03

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3ff71b39d2ad2eeb5113940c5de5593da0527b26
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2ZmNzFiMzlkMmFkMmVlYjUxMTM5NDBjNWRlNTU5M2RhMDUyN2IyNiJ9
BEGIN_NESTED_COMMIT
fix(aiplatform): Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData
feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
docs: minor changes to comments

PiperOrigin-RevId: 597666793

Source-Link: googleapis/googleapis@84ee19c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8dc3e3e32043acd6893bed96a6b4566f00843329
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGRjM2UzZTMyMDQzYWNkNjg5M2JlZDk2YTZiNDU2NmYwMDg0MzMyOSJ9
END_NESTED_COMMIT

…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
docs: minor changes to comments

PiperOrigin-RevId: 597666793

Source-Link: googleapis/googleapis@84ee19c

Source-Link: googleapis/googleapis-gen@8dc3e3e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGRjM2UzZTMyMDQzYWNkNjg5M2JlZDk2YTZiNDU2NmYwMDg0MzMyOSJ9
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData fix!(aiplatform)!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 12, 2024 01:14
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 12, 2024 01:14
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
…nsorboardTimeSeries and BatchReadTensorboardTimeSeriesData

feat: add models to CustomJobSpec
feat: add max_wait_duration to Scheduling
feat: add CountTokens method to llm_utility_service
docs: minor changes to comments

PiperOrigin-RevId: 597667108

Source-Link: googleapis/googleapis@714ab03

Source-Link: googleapis/googleapis-gen@3ff71b3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2ZmNzFiMzlkMmFkMmVlYjUxMTM5NDBjNWRlNTU5M2RhMDUyN2IyNiJ9
@gcf-owl-bot gcf-owl-bot bot changed the title fix!(aiplatform)!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot requested review from a team and shollyman as code owners January 12, 2024 01:22
@gcf-owl-bot gcf-owl-bot bot requested a review from cindy-peng January 12, 2024 01:22
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
Copy link

snippet-bot bot commented Jan 12, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData fix!(aiplatform)!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData Jan 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@noahdietz noahdietz changed the title fix!(aiplatform)!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData fix(aiplatform)!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData Jan 12, 2024
@noahdietz noahdietz changed the title fix(aiplatform)!: Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData fix(aiplatform): Fix rpc tensorboard_service.proto definitions for BatchCreateTensorboardTimeSeries and BatchReadTensorboardTimeSeriesData Jan 12, 2024
@noahdietz
Copy link
Contributor

The alleged breaking change for aiplatform was an HTTP pattern fix. No surface breakage.

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Jan 12, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 04ce84d into main Jan 12, 2024
13 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch January 12, 2024 02:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 12, 2024
@release-please release-please bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
owl-bot-copy size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants