Skip to content

Commit

Permalink
set_parent_pom.sh to exclude java-shared-dependencies
Browse files Browse the repository at this point in the history
The java-shared-dependencies should not depend on google-cloud-jar
parent because it imports java-shared-dependencies.
  • Loading branch information
suztomo committed Feb 1, 2023
1 parent 993b1e3 commit 16ccbb6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion generation/set_parent_pom.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ function replaceParent {
# Then, apply the values as the parent pom of each module
for module in $(find . -mindepth 2 -maxdepth 2 -name pom.xml | sort --dictionary-order | xargs dirname); do
# example value of module is "./java-accessapproval"
if [[ "${module}" = *gapic-libraries-bom ]] || [[ "${module}" = *google-cloud-jar-parent ]] || [[ "${module}" = *google-cloud-pom-parent ]]; then
if [[ "${module}" = *gapic-libraries-bom ]] || \
[[ "${module}" = *google-cloud-jar-parent ]] || \
[[ "${module}" = *google-cloud-pom-parent ]] || \
[[ "${module}" = *java-shared-dependencies ]]; then
continue
fi
echo "Processing module $module"
Expand Down
1 change: 1 addition & 0 deletions java-core/google-cloud-core-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<artifactId>google-cloud-core-bom</artifactId>
<version>2.9.5-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
<packaging>pom</packaging>

<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pom-parent</artifactId>
Expand Down

0 comments on commit 16ccbb6

Please sign in to comment.