-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
06857f3
commit afe98d2
Showing
1 changed file
with
3 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afe98d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JesseLovelace Just a nit that I've fixed elsewhere [1] -- if the string we're using includes a scheme, it's no longer just the "host" segment of a URI; can we call it something like
DEFAULT_BASE_URL
instead ofDEFAULT_HOST
, or just populate the string value without the scheme? It's harder to reason about code that passes these things around when they're mislabeled.[1]
google-cloud-java/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageImpl.java
Line 91 in afe98d2