(storage) Fix default host #7034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #7034 +/- ##
=========================================
Coverage 32.16% 32.16%
- Complexity 3696 3702 +6
=========================================
Files 249 249
Lines 40369 40369
Branches 6134 6133 -1
=========================================
Hits 12984 12984
Misses 26315 26315
Partials 1070 1070
Continue to review full report at Codecov.
|
BenWhitehead
added a commit
to googleapis/java-storage
that referenced
this pull request
Nov 18, 2021
…1142) When calling `StorageOptions#toBuilder()` after creating the builder the host was explicitly set to the default host. This change removes that behavior instead moving the setting of the default host to the instantiation of a new builder. Add unit tests to ensure host is set to the expected values based on different ways of creating an instance of StorageOptions. Related: * googleapis/google-cloud-java#6579 * googleapis/google-cloud-java#7004 * googleapis/google-cloud-java#7034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7004