Remove reflection to get App Engine credentials and project ID #763
Assignees
Labels
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
ajkannan
added
type: bug
|
Update: this won't fix the issue. The SDK dependency is used to set whether the APIs are available on app engine or not in the I'll keep this issue open because we can still implement the suggestion above for minor performance improvements. |
|
Closing this as the benefits are quite small compared to the effort required. Any CPU performance benefit from avoiding reflection is dwarfed by the time it takes for the subsequent RPC call to complete. |
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this issue
Jun 29, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Jun 30, 2022
Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot
pushed a commit
that referenced
this issue
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Sep 15, 2022
…ator_java versions (#763) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: googleapis/googleapis-gen@230a558 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9
github-actions bot
pushed a commit
that referenced
this issue
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [2.5.5](https://togithub.com/googleapis/java-bigqueryconnection/compare/v2.5.4...v2.5.5) (2022-10-03) ### Dependencies * Update dependency certifi to v2022.9.24 ([#758](https://togithub.com/googleapis/java-bigqueryconnection/issues/758)) ([8b12153](https://togithub.com/googleapis/java-bigqueryconnection/commit/8b12153365780e57dae0bb5254b9fd36f313d51d)) * Update dependency charset-normalizer to v2.1.1 ([#762](https://togithub.com/googleapis/java-bigqueryconnection/issues/762)) ([c912d0a](https://togithub.com/googleapis/java-bigqueryconnection/commit/c912d0a9b466c33d3fe2dc51e04a8f3f560391e1)) * Update dependency click to v8.1.3 ([#763](https://togithub.com/googleapis/java-bigqueryconnection/issues/763)) ([3270445](https://togithub.com/googleapis/java-bigqueryconnection/commit/3270445bfe9ece2a737cb40768b5613ce730af35)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#784](https://togithub.com/googleapis/java-bigqueryconnection/issues/784)) ([5e41cd8](https://togithub.com/googleapis/java-bigqueryconnection/commit/5e41cd883f1a1a37b5ad93b76d3c4c7685056787)) * Update dependency com.google.protobuf:protobuf-java-util to v3.21.7 ([#782](https://togithub.com/googleapis/java-bigqueryconnection/issues/782)) ([9d0fe12](https://togithub.com/googleapis/java-bigqueryconnection/commit/9d0fe12996d6e401ed94a759af80bb1950278e39)) * Update dependency gcp-releasetool to v1.8.8 ([#759](https://togithub.com/googleapis/java-bigqueryconnection/issues/759)) ([9955b8f](https://togithub.com/googleapis/java-bigqueryconnection/commit/9955b8f5b4fbcdfc0636c8bd7a14aeae9807363c)) * Update dependency google-api-core to v2.10.1 ([#764](https://togithub.com/googleapis/java-bigqueryconnection/issues/764)) ([aa07e7f](https://togithub.com/googleapis/java-bigqueryconnection/commit/aa07e7faa6618cc644681b0bba7c2c3d7cac3e07)) * Update dependency google-auth to v2.12.0 ([#765](https://togithub.com/googleapis/java-bigqueryconnection/issues/765)) ([b896e86](https://togithub.com/googleapis/java-bigqueryconnection/commit/b896e863a92b5fd07395b8064b990c96a0d29ddd)) * Update dependency google-cloud-core to v2.3.2 ([#760](https://togithub.com/googleapis/java-bigqueryconnection/issues/760)) ([0241ee4](https://togithub.com/googleapis/java-bigqueryconnection/commit/0241ee4ed6db5e6a83db1229fec89305f4168811)) * Update dependency google-cloud-storage to v2.5.0 ([#766](https://togithub.com/googleapis/java-bigqueryconnection/issues/766)) ([7064657](https://togithub.com/googleapis/java-bigqueryconnection/commit/7064657a1ceffee5ddb8f0e7b7a7734b48d6b090)) * Update dependency google-crc32c to v1.5.0 ([#767](https://togithub.com/googleapis/java-bigqueryconnection/issues/767)) ([350b87a](https://togithub.com/googleapis/java-bigqueryconnection/commit/350b87a782357097dd28bc7b847c61afb25f90a6)) * Update dependency googleapis-common-protos to v1.56.4 ([#761](https://togithub.com/googleapis/java-bigqueryconnection/issues/761)) ([11824d3](https://togithub.com/googleapis/java-bigqueryconnection/commit/11824d354e6cad62e6c2ee5c500b24bc3659c9d8)) * Update dependency importlib-metadata to v4.12.0 ([#768](https://togithub.com/googleapis/java-bigqueryconnection/issues/768)) ([dfa42e5](https://togithub.com/googleapis/java-bigqueryconnection/commit/dfa42e5d75b698987a86a980a404789ef74c68ce)) * Update dependency jeepney to v0.8.0 ([#769](https://togithub.com/googleapis/java-bigqueryconnection/issues/769)) ([44f5e0c](https://togithub.com/googleapis/java-bigqueryconnection/commit/44f5e0c34a0d2680a9d79bd129061acd6cfd8e4f)) * Update dependency jinja2 to v3.1.2 ([#778](https://togithub.com/googleapis/java-bigqueryconnection/issues/778)) ([192246f](https://togithub.com/googleapis/java-bigqueryconnection/commit/192246f0c33ec126bf3f3739c2dec0fbc05bf83e)) * Update dependency keyring to v23.9.3 ([#779](https://togithub.com/googleapis/java-bigqueryconnection/issues/779)) ([73daa64](https://togithub.com/googleapis/java-bigqueryconnection/commit/73daa64628deaa7542a98dcb6b056b625cca9f86)) * Update dependency markupsafe to v2.1.1 ([#770](https://togithub.com/googleapis/java-bigqueryconnection/issues/770)) ([0b1e0d9](https://togithub.com/googleapis/java-bigqueryconnection/commit/0b1e0d9f3be5f59a1ddb254e065b5c659da6b9b6)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](https://togithub.com/googleapis/java-websecurityscanner/compare/v2.2.4...v2.3.0) (2022-10-04) ### Features * Added NO_STARTING_URL_FOUND_FOR_MANAGED_SCAN to ScanRunWarningTrace.Code ([#741](https://togithub.com/googleapis/java-websecurityscanner/issues/741)) ([bdc4af4](https://togithub.com/googleapis/java-websecurityscanner/commit/bdc4af46ed6d1d690c60b336e9769fc9ad087578)) ### Bug Fixes * Added fix to return a list of the endpoints that encountered errors during crawl, along with the specific error message when the starting URL returns Http errors ([bdc4af4](https://togithub.com/googleapis/java-websecurityscanner/commit/bdc4af46ed6d1d690c60b336e9769fc9ad087578)) * GoogleAccount is deprecated ([bdc4af4](https://togithub.com/googleapis/java-websecurityscanner/commit/bdc4af46ed6d1d690c60b336e9769fc9ad087578)) * update protobuf to v3.21.7 ([607ea93](https://togithub.com/googleapis/java-websecurityscanner/commit/607ea935cee44edf4c744fcf8d1103b7475c7859)) ### Dependencies * Update dependency cachetools to v5 ([#761](https://togithub.com/googleapis/java-websecurityscanner/issues/761)) ([5c48ffb](https://togithub.com/googleapis/java-websecurityscanner/commit/5c48ffba59c9e119ef8aa07ad9eed4e2bc1df8f4)) * Update dependency certifi to v2022.9.24 ([#754](https://togithub.com/googleapis/java-websecurityscanner/issues/754)) ([45a6597](https://togithub.com/googleapis/java-websecurityscanner/commit/45a65974f15738845d223138f908698c204cf702)) * Update dependency charset-normalizer to v2.1.1 ([#763](https://togithub.com/googleapis/java-websecurityscanner/issues/763)) ([e151a7d](https://togithub.com/googleapis/java-websecurityscanner/commit/e151a7dbafec413768861781c8ff3693e5be1e16)) * Update dependency click to v8.1.3 ([#764](https://togithub.com/googleapis/java-websecurityscanner/issues/764)) ([57f034c](https://togithub.com/googleapis/java-websecurityscanner/commit/57f034cc8733502e9cab72ecd4efd72e33a483c4)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#774](https://togithub.com/googleapis/java-websecurityscanner/issues/774)) ([a4ca862](https://togithub.com/googleapis/java-websecurityscanner/commit/a4ca8621e8b263d69b273770e0674ce2f44c8024)) * Update dependency gcp-releasetool to v1.8.8 ([#755](https://togithub.com/googleapis/java-websecurityscanner/issues/755)) ([88ecda6](https://togithub.com/googleapis/java-websecurityscanner/commit/88ecda6da20ad542fc2ad3360eee1864e9bdf95b)) * Update dependency google-api-core to v2.10.1 ([#765](https://togithub.com/googleapis/java-websecurityscanner/issues/765)) ([e5e3f7b](https://togithub.com/googleapis/java-websecurityscanner/commit/e5e3f7b50c8c8b9691716557a960d7f10a49dbd5)) * Update dependency google-auth to v2.11.1 ([#756](https://togithub.com/googleapis/java-websecurityscanner/issues/756)) ([26d68c6](https://togithub.com/googleapis/java-websecurityscanner/commit/26d68c63c6804c8d16c3f37b69de1c46efb92f34)) * Update dependency google-cloud-core to v2.3.2 ([#757](https://togithub.com/googleapis/java-websecurityscanner/issues/757)) ([625a1da](https://togithub.com/googleapis/java-websecurityscanner/commit/625a1da75640ee857c63bc6ad652bc4b07215438)) * Update dependency google-cloud-storage to v2.5.0 ([#766](https://togithub.com/googleapis/java-websecurityscanner/issues/766)) ([ec32fb7](https://togithub.com/googleapis/java-websecurityscanner/commit/ec32fb7d4909301d8db8c15c66ac6f8039bef1bb)) * Update dependency googleapis-common-protos to v1.56.4 ([#758](https://togithub.com/googleapis/java-websecurityscanner/issues/758)) ([48a2f9a](https://togithub.com/googleapis/java-websecurityscanner/commit/48a2f9a0fcf1cedc2e77c9ee301f89d69dcf199c)) * Update dependency joda-time:joda-time to v2.11.2 ([#751](https://togithub.com/googleapis/java-websecurityscanner/issues/751)) ([ccabb8e](https://togithub.com/googleapis/java-websecurityscanner/commit/ccabb8ef52ad1459c51ced253a4091c479684609)) * Update dependency protobuf to v4 ([#762](https://togithub.com/googleapis/java-websecurityscanner/issues/762)) ([50d6147](https://togithub.com/googleapis/java-websecurityscanner/commit/50d6147d2ff53de31d8fd3b7248d4d0be62f58e5)) * Update dependency zipp to v3.8.1 ([#760](https://togithub.com/googleapis/java-websecurityscanner/issues/760)) ([f6f5547](https://togithub.com/googleapis/java-websecurityscanner/commit/f6f55472157b78d1b1acfe48b9f067922230bbb8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Nov 9, 2022
…1.4 (#763) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigqueryreservation). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC45LjIifQ==-->
](https://renovatebot.com){kind=link}
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
….2.10 (#763) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam) | `1.2.9` -> `1.2.10` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.2.10`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​1210-httpsgithubcomgoogleapisjava-iamcomparev129v1210-2022-03-10) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.2.9...v1.2.10) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/java-shared-dependencies@v2.13.0...v3.0.0) (2022-07-29) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-shared-dependencies/issues/1485)) ([#738](googleapis/java-shared-dependencies#738)) ([48b157d](googleapis/java-shared-dependencies@48b157d)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.35.2 ([#729](googleapis/java-shared-dependencies#729)) ([d518319](googleapis/java-shared-dependencies@d518319)) * update dependency com.google.api-client:google-api-client-bom to v2 ([#746](googleapis/java-shared-dependencies#746)) ([ef2b57a](googleapis/java-shared-dependencies@ef2b57a)) * update dependency com.google.api.grpc:grpc-google-common-protos to v2.9.2 ([#741](googleapis/java-shared-dependencies#741)) ([347269f](googleapis/java-shared-dependencies@347269f)) * update dependency com.google.auth:google-auth-library-bom to v1.8.0 ([#726](googleapis/java-shared-dependencies#726)) ([236bbb3](googleapis/java-shared-dependencies@236bbb3)) * update dependency com.google.auth:google-auth-library-bom to v1.8.1 ([#742](googleapis/java-shared-dependencies#742)) ([dabdbdf](googleapis/java-shared-dependencies@dabdbdf)) * update dependency com.google.cloud:first-party-dependencies to v2 ([#747](googleapis/java-shared-dependencies#747)) ([93b1ed8](googleapis/java-shared-dependencies@93b1ed8)) * update dependency com.google.cloud:grpc-gcp to v1.2.1 ([#751](googleapis/java-shared-dependencies#751)) ([618b00c](googleapis/java-shared-dependencies@618b00c)) * update dependency com.google.cloud:third-party-dependencies to v2 ([#748](googleapis/java-shared-dependencies#748)) ([afca3fd](googleapis/java-shared-dependencies@afca3fd)) * update dependency com.google.http-client:google-http-client-bom to v1.42.1 ([#730](googleapis/java-shared-dependencies#730)) ([4fdaad8](googleapis/java-shared-dependencies@4fdaad8)) * update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#749](googleapis/java-shared-dependencies#749)) ([68a82f4](googleapis/java-shared-dependencies@68a82f4)) * update dependency com.google.protobuf:protobuf-bom to v3.21.2 ([#722](googleapis/java-shared-dependencies#722)) ([68f570e](googleapis/java-shared-dependencies@68f570e)) * update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#756](googleapis/java-shared-dependencies#756)) ([7429507](googleapis/java-shared-dependencies@7429507)) * update dependency com.google.protobuf:protobuf-bom to v3.21.4 ([#759](googleapis/java-shared-dependencies#759)) ([f033db0](googleapis/java-shared-dependencies@f033db0)) * update dependency io.grpc:grpc-bom to v1.48.0 ([#752](googleapis/java-shared-dependencies#752)) ([9678d52](googleapis/java-shared-dependencies@9678d52)) * update dependency org.checkerframework:checker-qual to v3.23.0 ([#736](googleapis/java-shared-dependencies#736)) ([816d380](googleapis/java-shared-dependencies@816d380)) * update gax.version to v2.18.3 ([#731](googleapis/java-shared-dependencies#731)) ([5bbf1e1](googleapis/java-shared-dependencies@5bbf1e1)) * update gax.version to v2.18.4 ([#735](googleapis/java-shared-dependencies#735)) ([5161c6e](googleapis/java-shared-dependencies@5161c6e)) * update gax.version to v2.18.5 ([#758](googleapis/java-shared-dependencies#758)) ([608e040](googleapis/java-shared-dependencies@608e040)) * update gax.version to v2.18.6 ([#763](googleapis/java-shared-dependencies#763)) ([84b81e9](googleapis/java-shared-dependencies@84b81e9)) * update google.common-protos.version to v2.9.1 ([#724](googleapis/java-shared-dependencies#724)) ([62cd59a](googleapis/java-shared-dependencies@62cd59a)) * update google.core.version to v2.8.1 ([#725](googleapis/java-shared-dependencies#725)) ([d47af56](googleapis/java-shared-dependencies@d47af56)) * update google.core.version to v2.8.3 ([#760](googleapis/java-shared-dependencies#760)) ([33e38dc](googleapis/java-shared-dependencies@33e38dc)) * update google.core.version to v2.8.4 ([#762](googleapis/java-shared-dependencies#762)) ([5410450](googleapis/java-shared-dependencies@5410450)) * update google.core.version to v2.8.5 ([#764](googleapis/java-shared-dependencies#764)) ([4bc8c75](googleapis/java-shared-dependencies@4bc8c75)) * update iam.version to v1.5.0 ([#732](googleapis/java-shared-dependencies#732)) ([3e64541](googleapis/java-shared-dependencies@3e64541)) * update iam.version to v1.5.1 ([#737](googleapis/java-shared-dependencies#737)) ([5a85115](googleapis/java-shared-dependencies@5a85115)) * update iam.version to v1.5.2 ([#743](googleapis/java-shared-dependencies#743)) ([294ea85](googleapis/java-shared-dependencies@294ea85)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In production App Engine (standard runtime), reflection to get project ID and credentials won't work unless the user depends on appengine-api-1.0-sdk, even though the necessary jars are already provided by the runtime. To get around this, we should declare a "provided"-scoped dependency on that library in
gcloud-java-coreand use theAppIdentityServicedirectly instead of through reflection to get credentials and the project ID.The text was updated successfully, but these errors were encountered: