Create base class for serialization tests #754

mziccard · 2016-03-16T08:41:23Z

This fixes #657 and #676 by adding a base class for serialization tests as well as a SerializationTest to gcloud-java-core.

To achieve this I had to add a new execution goal to our build (text-jar) and add core's test jar as a test dependency to all our modules' poms.

...-java-resourcemanager/src/test/java/com/google/gcloud/resourcemanager/SerializationTest.java

 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import com.google.gcloud.Identity;
+import com.google.gcloud.BaseSerializationTest;


ajkannan · 2016-03-16T16:49:46Z

Just one or two nits from me + a couple outdated things that are unrelated to your PR (can either be fixed here or in the future if we create an issue).

mziccard · 2016-03-17T10:00:35Z

@ajkannan thanks for the feedback, you are right on everything so I tried to address all comments in 967c5c5

gcloud-java-core/src/test/java/com/google/gcloud/SerializationTest.java

+
+  @Test
+  public void testAuthCredentialState() throws IOException, ClassNotFoundException {
+    AuthCredentials credentials = AuthCredentials.createApplicationDefaults();


gcloud-java-core/src/main/java/com/google/gcloud/ExceptionHandler.java

+        && Objects.equals(retriableExceptions, other.retriableExceptions)
+        && Objects.equals(nonRetriableExceptions, other.nonRetriableExceptions)
+        && Objects.equals(retryInfo, other.retryInfo);
+


ajkannan · 2016-03-17T16:38:21Z

Nice, looks like Travis is passing now. Just finished another pass with two more comments.

mziccard · 2016-03-17T18:02:01Z

Guys thanks for the feedback, looks much nicer now. I think I addressed all comments but please have a look.

gcloud-java-core/src/main/java/com/google/gcloud/AuthCredentials.java

@@ -276,6 +276,16 @@ public GoogleCredentials credentials() {
      public AuthCredentials restore() {
        return INSTANCE;
      }
+


aozarov · 2016-03-17T21:21:29Z

Nice, looks good to me but I will let @ajkannan merge it after looking more carefully.

gcloud-java-core/src/test/java/com/google/gcloud/SerializationTest.java

+
+  @Override
+  protected Serializable[] serializableObjects() {
+    return new Serializable[]{EXCEPTION_HANDLER, IDENTITY, PAGE, RETRY_PARAMS};


aozarov · 2016-03-18T01:59:52Z

I looked a deepr look. Looks great! Feel free to merge after fixing the 2 issues mentioned.

…n tests

mziccard · 2016-03-18T15:19:44Z

@aozarov I addressed the comments. I added equals and hashCode method to BaseServiceException and added the service exceptions to all serialization tests. Please take one more look before we merge this in.

coveralls · 2016-03-18T15:39:02Z

Coverage increased (+1.07%) to 84.266% when pulling 83ddb08 on mziccard:serialization-tests into 7d48ec7 on GoogleCloudPlatform:master.

Create base class for serialization tests

🤖 I have created a release *beep* *boop* --- ## [3.4.1](googleapis/java-cloudbuild@v3.4.0...v3.4.1) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#754](googleapis/java-cloudbuild#754)) ([4a268e6](googleapis/java-cloudbuild@4a268e6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### [1.2.9](googleapis/java-resourcemanager@v1.2.8...v1.2.9) (2022-04-14) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.13.0 ([googleapis#753](googleapis/java-resourcemanager#753)) ([46fa1ea](googleapis/java-resourcemanager@46fa1ea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…is#754) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9

) * chore: update dependencies for regapic * add more dependencies and trigger comment * update goldens * fix indentation * remove duplicate gax-httpjson dependency * remove duplicated dependencies Source-Link: googleapis/synthtool@fa54eb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906

🤖 I have created a release *beep* *boop* --- ## [2.4.0](googleapis/java-accessapproval@v2.3.2...v2.4.0) (2022-06-30) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#754](googleapis/java-accessapproval#754)) ([8eb2549](googleapis/java-accessapproval@8eb2549)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.3.4](googleapis/java-billingbudgets@v2.3.3...v2.3.4) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#754](googleapis/java-billingbudgets#754)) ([2a54f46](googleapis/java-billingbudgets@2a54f46)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://togithub.com/googleapis/java-iamcredentials/compare/v2.3.5...v2.3.6) (2022-10-05) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#754](https://togithub.com/googleapis/java-iamcredentials/issues/754)) ([c70cc24](https://togithub.com/googleapis/java-iamcredentials/commit/c70cc240dfb6a9402e5c93ea6b6c52998637040b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…protection to v0.34.6 (googleapis#754) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-phishingprotection](https://togithub.com/googleapis/java-phishingprotection) | `0.34.4` -> `0.34.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-phishingprotection/0.34.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-phishingprotection/0.34.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-phishingprotection/0.34.6/compatibility-slim/0.34.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-phishingprotection/0.34.6/confidence-slim/0.34.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-phishingprotection).

Co-authored-by: Anthonios Partheniou <partheniou@google.com> Source-Link: googleapis/synthtool@9457e69 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a3fe0b4c75f322520f548e535ed329df1e475ace3cb4a979b78e003cb822636a Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

🤖 I have created a release *beep* *boop* --- ### [2.5.8](googleapis/java-core@v2.5.7...v2.5.8) (2022-03-08) ### Dependencies * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.8 ([#753](googleapis/java-core#753)) ([06a4fa6](googleapis/java-core@06a4fa6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Create base class for serialization tests

8ae8a1b

mziccard added testing type: cleanup An internal cleanup or hygiene concern. labels Mar 16, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2016

ajkannan reviewed Mar 16, 2016
View reviewed changes

mderka mentioned this pull request Mar 16, 2016

Migrate DNS to new common serialization #757

Closed

Add tests for restorable classes. Fix serialization issues

967c5c5

ajkannan reviewed Mar 17, 2016
View reviewed changes

gcloud-java-core/src/test/java/com/google/gcloud/SerializationTest.java

@Test

public void testAuthCredentialState() throws IOException, ClassNotFoundException {

AuthCredentials credentials = AuthCredentials.createApplicationDefaults();

This comment was marked as spam.

Sign in to view

Remove serialization test for ApplicationDefaultAuthCredentials

034432a

ajkannan reviewed Mar 17, 2016
View reviewed changes

Add restorableObjects method to BaseSerializationTest

ce59793

aozarov reviewed Mar 17, 2016
View reviewed changes

gcloud-java-core/src/main/java/com/google/gcloud/AuthCredentials.java

@@ -276,6 +276,16 @@ public GoogleCredentials credentials() {

public AuthCredentials restore() {

return INSTANCE;

}

This comment was marked as spam.

Sign in to view

aozarov reviewed Mar 18, 2016
View reviewed changes

gcloud-java-core/src/test/java/com/google/gcloud/SerializationTest.java

@Override

protected Serializable[] serializableObjects() {

return new Serializable[]{EXCEPTION_HANDLER, IDENTITY, PAGE, RETRY_PARAMS};

This comment was marked as spam.

Sign in to view

mziccard added 3 commits March 18, 2016 16:01

Make NoAuthCredentials constructor private

5c4e288

Add IamPolicy to SerializationTest

19e0c6e

Add equals and hashCode to exceptions. Add exceptions to serializatio…

83ddb08

…n tests

aozarov added a commit that referenced this pull request Mar 18, 2016

Merge pull request #754 from mziccard/serialization-tests

353d2db

Create base class for serialization tests

aozarov merged commit 353d2db into googleapis:master Mar 18, 2016

mziccard mentioned this pull request Apr 3, 2016

Refactor serialization test code. #657

Closed

suztomo pushed a commit that referenced this pull request Feb 1, 2023

chore(main): release 2.13.1-SNAPSHOT (#754)

7f4f401

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create base class for serialization tests #754

Create base class for serialization tests #754

mziccard commented Mar 16, 2016

This comment was marked as spam.

ajkannan commented Mar 16, 2016

mziccard commented Mar 17, 2016

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Mar 17, 2016

mziccard commented Mar 17, 2016

This comment was marked as spam.

aozarov commented Mar 17, 2016

This comment was marked as spam.

aozarov commented Mar 18, 2016

mziccard commented Mar 18, 2016

coveralls commented Mar 18, 2016

Create base class for serialization tests #754

Create base class for serialization tests #754

Conversation

mziccard commented Mar 16, 2016

This comment was marked as spam.

ajkannan commented Mar 16, 2016

mziccard commented Mar 17, 2016

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Mar 17, 2016

mziccard commented Mar 17, 2016

This comment was marked as spam.

aozarov commented Mar 17, 2016

This comment was marked as spam.

aozarov commented Mar 18, 2016

mziccard commented Mar 18, 2016

coveralls commented Mar 18, 2016