chore: generate grafeas #10820
Closed
chore: generate grafeas #10820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kokoro tests failed: |
JoeWang1127
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Header checks failed, the headers are changed by owlbot.py |
This reverts commit 13085dc.
JoeWang1127
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
May 13, 2024
In this PR:
- Add suffix to sample source folder
- Add unit tests
Context:
- The package name of grafeas is `io.grafeas.v1` which is not starts
with `com`. When copying samples to destination directory, we need to
change the suffix of source directory.
- grafeas doesn't have a valid api_id (empty string). Before this
change, the `api_id` will be populated as
`{library.api_shortname}.googleapis.com`, which is not correct. `api_id`
should not be populated to `.repo-metadata.json` if set to empty string.
With the library entry added in generation configuration:
```
- api_shortname: containeranalysis
name_pretty: Grafeas
product_documentation: https://grafeas.io
api_description: n/a
client_documentation: "https://cloud.google.com/java/docs/reference/grafeas/latest/overview"
release_level: stable
distribution_name: "io.grafeas:grafeas"
api_id: ""
codeowner_team: "@googleapis/aap-dpes"
library_name: grafeas
requires_billing: false
GAPICs:
- proto_path: grafeas/v1
```
The generated java-grafeas is in googleapis/google-cloud-java#10820
JoeWang1127
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
JoeWang1127
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
May 22, 2024
In this PR:
- Add suffix to sample source folder
- Add unit tests
Context:
- The package name of grafeas is `io.grafeas.v1` which is not starts
with `com`. When copying samples to destination directory, we need to
change the suffix of source directory.
- grafeas doesn't have a valid api_id (empty string). Before this
change, the `api_id` will be populated as
`{library.api_shortname}.googleapis.com`, which is not correct. `api_id`
should not be populated to `.repo-metadata.json` if set to empty string.
With the library entry added in generation configuration:
```
- api_shortname: containeranalysis
name_pretty: Grafeas
product_documentation: https://grafeas.io
api_description: n/a
client_documentation: "https://cloud.google.com/java/docs/reference/grafeas/latest/overview"
release_level: stable
distribution_name: "io.grafeas:grafeas"
api_id: ""
codeowner_team: "@googleapis/aap-dpes"
library_name: grafeas
requires_billing: false
GAPICs:
- proto_path: grafeas/v1
```
The generated java-grafeas is in googleapis/google-cloud-java#10820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.