chore: fix dependencies in java-dataproc #11109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes java-dataproc by changing its `gprc-google-iam-v1` to test-scoped. This however brings a compilation error because the proto classes transitively brought by the mentioned dependency are not available anymore. This is fixed by additionally bringing the `proto-google-iam-v1` as compile-scoped. More context in https://www.techradar.com/news/audio/portable-audio/best-noise-cancelling-headphones-1280490#section-the-best-premium-noise-cancelling-headphones
|
The Unmanaged Dependency check has been failing for a while in other PRs. I think it's fine since it talks about a pom not touched in this PR. |
blakeli0
reviewed
Sep 3, 2024
| <dependency> | ||
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>grpc-google-iam-v1</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Thanks, my editor would not show this problem. I changed this to spaces.
blakeli0
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes java-dataproc by changing its
gprc-google-iam-v1to test-scoped. This however brings a compilation error because the proto classes transitively brought by the mentioned dependency are not available anymore. This is fixed by additionally bringing theproto-google-iam-v1as compile-scoped.More context in
googleapis/sdk-platform-java#3072 (review)