Add a PathMatcher for CloudStorageFileSystem #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test, as well. We reuse the default PathMatcher since it does a fine job of globbing files.
googlebot
added
the
cla: yes
| for (int i=0; i<paths.size(); i++) { | ||
| Path input = fs.getPath(paths.get(i)).getFileName(); | ||
| assertWithMessage(pattern1 + " on " + paths.get(i)).that(matcher1.matches(input)).isEqualTo(matches1.get(i)); | ||
| assertWithMessage(pattern2 + " on " + paths.get(i)).that(matcher2.matches(input)).isEqualTo(matches2.get(i)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
(it still does the same thing)
| public void testMatcher() throws IOException { | ||
| try (FileSystem fs = CloudStorageFileSystem.forBucket("bucket")) { | ||
| String pattern1 = "glob:*.java"; | ||
| PathMatcher matcher1 = fs.getPathMatcher(pattern1); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| String pattern1 = "glob:*.java"; | ||
| PathMatcher matcher1 = fs.getPathMatcher(pattern1); | ||
| String pattern2 = "glob:*.{java,text}"; | ||
| PathMatcher matcher2 = fs.getPathMatcher(pattern2); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jean-philippe-martin
force-pushed
the
jp_matcher
branch
from
034ab6b
to
64ca46e
Compare
pongad
added a commit
that referenced
this pull request
Feb 7, 2017
* Update version to 0.8.1-SNAPSHOT (#1467) Also, update versions in README to 0.8.0 * Add link to Maven Central for maven-central badge. (#1468) Used to link to the image, which wasn't super useful. * fix more races in pubsub tests Previously BlockingProcessStreamReader has a terminate() method, used to tell the Reader to stop reading from the emulator process. This causes an inter-process race. If the Reader stops before reading emulator's output, the emulator process will hang as it tries to write to stdout/stderr as there's no one to read from the other side of the pipe. Since there is no way to safely stop the Reader, this commit deletes the method and its associated test. Additionally, the timeout for LocalSystemTest is increased to 3 minutes, since the emulator, somehow, consistently takes just longer than a minute to shut down. * Regenerating SPI layer (#1501) * Converting Error Reporting and Monitoring to use resource name types * Removing formatX/parseX methods from pubsub, converting usage of the same to resource name types * New methods in Logging and PubSub * Updating grpc dependency to 1.0.3 (#1504) * Release 0.8.1 (#1512) * Fix code snippet (wrong method name) in README.md Original code snippet in _"Querying data"_ section: `..while (!queryResponse.jobComplete()) {..` This results in a compile error: _"Cannot resolve method jobComplete()"_ The correct method is `jobCompleted()` * Updating version in README files. [ci skip] * Update version to 0.8.2-alpha-SNAPSHOT * Allow path in URIs passed to newFileSystem (#1470) * This makes it easier for users who start with a URI describing a full path to get a FileSystem that can work with that path, since they no longer have to needlessly remove the path from the URI. Note that Oracle's description of newFileSystem [1] puts no restriction on the passed URI. [1] https://docs.oracle.com/javase/7/docs/api/java/nio/file/FileSystems.html#newFileSystem(java.net.URI,%20java.util.Map) * Preventing logging re-entrance at FINE level (#1523) * Preventing logging re-entrance at FINE level Also: * Reducing the scope of synchronized blocks * Removing logger exclusions except for Http2FrameLogger * Add a PathMatcher for CloudStorageFileSystem (#1469) Add a test, as well. We reuse the default PathMatcher since it does a fine job of globbing files. * Set timestamp from LogRecord (#1533) * Initialize the default MonitoredResource from a GAE environment (#1535) * BigQuery: Add support to FormatOptions for AVRO #1441 Added new constant in FormatOptions, and a corresponding factory method. Updated test cases. Confirmed that AVRO does not require special treatment (like CSV does), so no additional changes are required. * Reverting changed commited by mistake before review. * BigQuery: Add support to FormatOptions for AVRO #1441 Added new constant in FormatOptions and a corresponding factory method. Updated test cases. Confirmed that AVRO does not require special treatment (like CSV does), so no additional changes are required. * use RpcFuture and remove old BundlingSettings (#1572) * use RpcFuture and remove old BundlingSettings * Release 0.8.2 Note: This version was accidentally released to Sonatype because of experimenting with deployment commands, combined with the fact that autoReleaseAfterClose is set to true. Since releases can't be taken back, we might as well own up to the release and push the code forward. * Updating version in README files. [ci skip] * Fixing javadoc error in GaeFlexLoggingEnhancer (#1582) * get tests to compile and pass
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…apis#826) Source-Link: googleapis/synthtool@0238f3d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7410586c94c608ea884879fa4083754cc28601909484c5987f4ea784da54b881
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…apis#907) Source-Link: googleapis/synthtool@0238f3d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7410586c94c608ea884879fa4083754cc28601909484c5987f4ea784da54b881
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…apis#322) Source-Link: googleapis/synthtool@0238f3d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7410586c94c608ea884879fa4083754cc28601909484c5987f4ea784da54b881
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-workflow-executions@v2.2.1...v2.3.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#311](googleapis/java-workflow-executions#311)) ([fc53408](googleapis/java-workflow-executions@fc53408)) * java template no longer require clirr ([googleapis#1469](https://github.com/googleapis/java-workflow-executions/issues/1469)) ([googleapis#322](googleapis/java-workflow-executions#322)) ([3a88c55](googleapis/java-workflow-executions@3a88c55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [1.9.0](googleapis/java-datacatalog@v1.8.4...v1.9.0) (2022-07-01) ### Features * java template no longer require clirr ([googleapis#1469](https://github.com/googleapis/java-datacatalog/issues/1469)) ([googleapis#826](googleapis/java-datacatalog#826)) ([38435e9](googleapis/java-datacatalog@38435e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.5.0](googleapis/java-speech@v2.4.0...v2.5.0) (2022-07-01) ### Features * java template no longer require clirr ([googleapis#1469](https://github.com/googleapis/java-speech/issues/1469)) ([googleapis#907](googleapis/java-speech#907)) ([5ce12b6](googleapis/java-speech@5ce12b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test, as well.
We reuse the default PathMatcher since it does a fine job of globbing files.
solves: #813