Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial submission of generated pubsub protobuf classes #322

Merged
merged 2 commits into from
Nov 5, 2015
Merged

Initial submission of generated pubsub protobuf classes #322

merged 2 commits into from
Nov 5, 2015

Conversation

garrettjonesgoogle
Copy link
Member

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2015
aozarov
aozarov reviewed Nov 4, 2015
View reviewed changes
gcloud-java-pubsub/README.md
@@ -0,0 +1,25 @@
Google Cloud Java Client for Pub/Sub

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@aozarov
Copy link
Contributor

aozarov commented Nov 4, 2015

I think we should discuses package names.

Until now, an API for a service XXX would live under com.google.gcloud.xxx and its SPI classes would live in the same maven module but using a shared package com.google.gcloud.spi (these included only few classes and were prefixed with the Service name).

We decided to prefix gcloud-java packages with com.google.gcloud in order to avoid any future
collisions with service specific classes or its low-level apiary/gRPC client classes.

I wonder if we should start nesting spi classes under their specific service (e.g. com.google.gcloud.pubsub.spi) and if the classes in this PR should use that package instead of com.google.pubsub.

As discussed earlier spi classes are publicly accessible (so can be used directly) however don't go through the same process (test-coverage, documentation,...), therefore we need some way to distinct between the two.

@garrettjonesgoogle
Copy link
Member Author

The classes in this particular review are low-level proto classes; the package name in use here is determined by pubsub.proto and isn't under our control. The idiomatic wrapper class for pubsub will come in a later review, and I was intending on putting that under the spi namespace.

@aozarov
Copy link
Contributor

aozarov commented Nov 4, 2015

Oh, I see. Sounds good.

Differently from gax, this is going to stay in this repository.
Any reason to check in the proto-generated classes instead of generating it at build time?
Looks like maven supports it, right?

@garrettjonesgoogle
Copy link
Member Author

Actually, I don't know if it is finalized that the generated pubsub classes will live here. We'd like to check these in now for that reason; trying to get maven to compile these might just be throwaway work.

PS I also updated the README.md file per your request.

@aozarov
Copy link
Contributor

aozarov commented Nov 5, 2015

Ok, I assumed using the Maven Protoc Plugin is trivial but as you said we can change it later.

Yes, I think it would be great if there is a separate maven artifact for each service protobuf generated classes. Is that the plan?

aozarov added a commit that referenced this pull request Nov 5, 2015
@aozarov
Merge pull request #322 from garrettjonesgoogle/pubsub-alpha
9e3b1e4 
Initial submission of generated pubsub protobuf classes
@aozarov aozarov merged commit 9e3b1e4 into googleapis:pubsub-alpha Nov 5, 2015
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-resource…
20d9a43 
…manager to v0.118.5-alpha (googleapis#322)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:google-cloud-resourcemanager](https://togithub.com/GoogleCloudPlatform/google-cloud-java) | patch | `0.118.4-alpha` -> `0.118.5-alpha` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@gcf-owl-bot
feat: java template no longer require clirr (googleapis#1469) (google…
3a88c55 
…apis#322)

Source-Link: googleapis/synthtool@0238f3d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7410586c94c608ea884879fa4083754cc28601909484c5987f4ea784da54b881
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@release-please
chore: release 2.0.2 (#322)
26b58cc 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.0.2](https://www.github.com/googleapis/java-workflows/compare/v2.0.1...v2.0.2) (2021-08-23)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.1.0 ([#321](https://www.github.com/googleapis/java-workflows/issues/321)) ([332dfd5](https://www.github.com/googleapis/java-workflows/commit/332dfd508eaac6f6ca2d2f5b463df3c80ae9e435))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 2.3.0 (googleapis#323)
32479ea 
🤖 I have created a release *beep* *boop*
---


## [2.3.0](googleapis/java-workflow-executions@v2.2.1...v2.3.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#311](googleapis/java-workflow-executions#311)) ([fc53408](googleapis/java-workflow-executions@fc53408))
* java template no longer require clirr ([googleapis#1469](https://github.com/googleapis/java-workflow-executions/issues/1469)) ([googleapis#322](googleapis/java-workflow-executions#322)) ([3a88c55](googleapis/java-workflow-executions@3a88c55))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Jul 6, 2022
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
cd0b660 
…onfig to v1.5.1 (#322)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.0` -> `1.5.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/compatibility-slim/1.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.1/confidence-slim/1.5.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.5.1`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;151-httpsgithubcomgoogleapisjava-shared-configcomparev150v151-2022-06-30)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.0...v1.5.1)

##### Dependencies

-   update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#&#8203;482](https://togithub.com/googleapis/java-shared-config/issues/482)) ([fbfc6dc](https://togithub.com/googleapis/java-shared-config/commit/fbfc6dc1329faaead3a3114c8599d9267722e7f0))
-   update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#&#8203;483](https://togithub.com/googleapis/java-shared-config/issues/483)) ([336cb78](https://togithub.com/googleapis/java-shared-config/commit/336cb7827b36583228c9e2b85871ae72f4c55975))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-channel).
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@gcf-owl-bot
fix: enable longpaths support for windows test (#1485) (#322)
4c3d7bc 
Source-Link: googleapis/synthtool@7336562
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 2.3.7 (#323)
2d9f17b 
🤖 I have created a release *beep* *boop*
---


## [2.3.7](googleapis/java-contact-center-insights@v2.3.6...v2.3.7) (2022-07-13)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-contact-center-insights/issues/1485)) ([#322](googleapis/java-contact-center-insights#322)) ([4c3d7bc](googleapis/java-contact-center-insights@4c3d7bc))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
@release-please
chore(main): release 1.2.8 (#322)
bf6170b 
🤖 I have created a release *beep* *boop*
---


## [1.2.8](https://togithub.com/googleapis/java-networkconnectivity/compare/v1.2.7...v1.2.8) (2022-10-03)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#321](https://togithub.com/googleapis/java-networkconnectivity/issues/321)) ([888f541](https://togithub.com/googleapis/java-networkconnectivity/commit/888f54116d70a9668bd127f1f4d7148791567b79))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Nov 9, 2022
@gcf-owl-bot
chore: Set rest_numeric_enums = False for all gapic rules explicitly (
7fba1d6 
#322)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 485623855

Source-Link: https://togithub.com/googleapis/googleapis/commit/807125e7953e32535710924fe4bf0362ac93754d

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9
github-actions bot pushed a commit that referenced this pull request Nov 17, 2022
@gcf-owl-bot @chingor13
chore(java): add a note in README for migrated split repos (#1687) (#322
cade51a 
)

* chore(java): add a note in README for migrated split repos

Disable renovate bot and flaky bot for split repositories
that have moved to the Java monorepo.
The Java monorepo will pass the "monorepo=True" parameter
to java.common_templates method in its owlbot.py files so that
the migration note will not appear in the README in the monorepo.

Co-authored-by: Jeff Ching <chingor@google.com>
Source-Link: googleapis/synthtool@d4b2916
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency io.grpc:grpc-stub to v1.45.1 (#322)
4ca5fd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettjonesgoogle @aozarov @googlebot