Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete publish-related methods from PubSub #1494

Merged
merged 2 commits into from
Jan 2, 2017
Merged

delete publish-related methods from PubSub #1494

merged 2 commits into from
Jan 2, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Dec 22, 2016

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bd4b537 on pongad:del-publish into ** on GoogleCloudPlatform:pubsub-hp**.

davidtorres
davidtorres reviewed Dec 22, 2016
View reviewed changes
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/PubSubImpl.java
String topicName =
PublisherClient.formatTopicName(getOptions().getProjectId(), topic.getName());
return Publisher.Builder.newBuilder(topicName)
.setCredentials(getOptions().getCredentials())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...le-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/TopicSnippets.java
* Example of publishing one message to the topic.
*/
// [TARGET publish(Message)]
public String publishOneMessage() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle reviewed Dec 27, 2016
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one rename request.

...le-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/TopicSnippets.java
* Example of publishing one message to the topic.
*/
// [TARGET publish(Message)]
public String publishOneMessage() {

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/PubSub.java
* the messages
*/
Future<List<String>> publishAsync(String topic, Iterable<Message> messages);
Publisher publisher(TopicInfo topic) throws IOException;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad pongad merged commit 6a4bc9d into googleapis:pubsub-hp Jan 2, 2017
@pongad pongad deleted the del-publish branch January 2, 2017 23:49
gcf-owl-bot bot added a commit that referenced this pull request Jul 19, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
52b25a4 
…ers for Java code (#1494)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
suztomo pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
6bfc327 
…ers for Java code (#1494) (#8019)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
ceb4609 
…ers for Java code (#1494) (#334)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
9d77580 
…ers for Java code (#1494) (#912)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
b4d61c9 
…ers for Java code (#1494) (#513)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
9a2e479 
…ers for Java code (#1494) (#889)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
d878c4c 
…ers for Java code (#1494) (#902)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
d0d0f57 
…ers for Java code (#1494) (#773)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
d239597 
…ers for Java code (#1494) (#287)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
f713258 
…ers for Java code (#1494) (#142)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
2db6e87 
…ers for Java code (#1494) (#527)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
ba10f2b 
…ers for Java code (#1494) (#448)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
ecc69f2 
…ers for Java code (#1494) (#478)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
0f3971c 
…ers for Java code (#1494) (#232)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
465feb5 
…ers for Java code (#1494) (#212)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
f9bfca7 
…ers for Java code (#1494) (#245)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
3ab87e0 
…ers for Java code (#1494) (#434)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
c998b58 
…ers for Java code (#1494) (#264)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
@gcf-owl-bot
ci: update template so GAPIC_AUTO repos do not require special approv…
1c00f70 
…ers for Java code (#1494) (#718)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
@gcf-owl-bot @xtineskim
ci: update template so GAPIC_AUTO repos do not require special approv…
10e3921 
…ers for Java code (#1494) (#760)

Source-Link: googleapis/synthtool@da89e53
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:04f254abfe5f47fe73ae6f91d68d55c3b76e722a4943066c3bb0ce03573b4ad9

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Christine Kim <35876108+ckim328@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtorres davidtorres davidtorres left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pongad @coveralls @davidtorres @garrettjonesgoogle @googlebot