Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Spanner DML #3761

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Revert Spanner DML #3761

merged 1 commit into from
Oct 3, 2018

Conversation

chingor13
Copy link
Contributor

This reverts commit 65ca2f3.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2018
@chingor13 chingor13 requested a review from a team October 3, 2018 05:02
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2018
vam-google
vam-google approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Please ensure that backend is completely ready before putting this change back.

@chingor13 chingor13 merged commit 68f38e1 into googleapis:master Oct 3, 2018
@chingor13 chingor13 deleted the revert-spanner-dml branch October 3, 2018 20:19
snehashah16 added a commit that referenced this pull request Oct 5, 2018
@snehashah16
Launch Cloud Spanner DML & PartitionedDML support
1c68385 
Revert "Revert "Revert "Revert "Cloud Spanner DML & PartitionedDML support (#3703)" (#3741)" (#3755)" (#3761)"

This reverts commit 68f38e1.
chingor13 pushed a commit that referenced this pull request Oct 5, 2018
@snehashah16 @chingor13
Cloud Spanner DML & PDML Release (#3781)
1e539fa 
* Launch Cloud Spanner DML & PartitionedDML support
Revert "Revert "Revert "Revert "Cloud Spanner DML & PartitionedDML support (#3703)" (#3741)" (#3755)" (#3761)"

This reverts commit 68f38e1.

* Cloud Spanner - Bug fix for seqNo, fix javadoc errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chingor13 @vam-google @googlebot @kokoro-team