Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata update to example and fix builder user-settable fields #58

Merged
merged 5 commits into from
May 14, 2015
Merged

Conversation

aozarov
Copy link
Contributor

@aozarov aozarov commented May 12, 2015

No description provided.

@aozarov aozarov assigned aozarov and jboynes and unassigned aozarov May 12, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) to 52.9% when pulling 6c59a54 on aozarov:master into 76776e3 on GoogleCloudPlatform:master.

@@ -336,6 +336,45 @@ public String params() {
}
}

private static class UpdateMetadata extends StorageAction<Tuple<Blob, Map<String, String>>> {

This comment was marked as spam.

This comment was marked as spam.

@jboynes
Copy link

jboynes commented May 13, 2015

This PR is a combination of different changes. It would be clearer if these were separate requests with their own descriptions

@coveralls
Copy link

Coverage Status

Coverage increased (+5.68%) to 58.71% when pulling 17ec594 on aozarov:master into 76776e3 on GoogleCloudPlatform:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+5.68%) to 58.71% when pulling 17ec594 on aozarov:master into 76776e3 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.68%) to 58.71% when pulling 4b8bd32 on aozarov:master into 76776e3 on GoogleCloudPlatform:master.

@aozarov
Copy link
Contributor Author

aozarov commented May 13, 2015

Changes were applied yesterday. Not sure if an explicit PTAL is expected.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.63%) to 58.66% when pulling 96b3ada on aozarov:master into 76776e3 on GoogleCloudPlatform:master.

@aozarov
Copy link
Contributor Author

aozarov commented May 13, 2015

I played few hours o deal with git and gitHub branches to avoid having the last commit "Replace given null values with Apiary nulls and provide doesNotExists" be part of this push request but unfortunately did one mistake (forgot to switch to my local branch before applying the patch which I had ready) and realized it after I pushed. This is not a big change and I don't want to play with rolling it back, so I leave it as part of this push. Honestly the process which I am following (maybe there is a better one) is annoying as I have to find the state of the master before my push request and branch from it each time to avoid including its pending changes so a quicker turn-around would be appreciated.

@jboynes
Copy link

jboynes commented May 14, 2015

There's a lot of stuff that got added here - it will take me a little while to go through it.
The workflow I use, which I think is pretty typical git, it to have separate branches for separate features and then merge between them as needed. If there are dependent changes, then rebase off the parent branch after merging in the feedback.

@aozarov
Copy link
Contributor Author

aozarov commented May 14, 2015

The issue for me was co-coordinating it with gitHub (and basically making
sure that the branch does not include what is already pending).
I didn't add much today and many of the previous changes are trivial such
making things final and overriding equals and hashCode.

Arie | Ozarov | ozarov@google.com | 415-624-6429

On Wed, May 13, 2015 at 5:01 PM, Jeremy Boynes notifications@github.com
wrote:

There's a lot of stuff that got added here - it will take me a little
while to go through it.
The workflow I use, which I think is pretty typical git, it to have
separate branches for separate features and then merge between them as
needed. If there are dependent changes, then rebase off the parent branch
after merging in the feedback.


Reply to this email directly or view it on GitHub
#58 (comment)
.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.63%) to 58.66% when pulling 0299172 on aozarov:master into 76776e3 on GoogleCloudPlatform:master.

jboynes added a commit that referenced this pull request May 14, 2015
add metadata update to example and fix builder user-settable fields
@jboynes jboynes merged commit 05e3f0a into googleapis:master May 14, 2015
jboynes added a commit that referenced this pull request Jul 1, 2015
add metadata update to example and fix builder user-settable fields
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
…onfig to v1.5.0 (#58)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/compatibility-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/confidence-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.5.0`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;150-httpsgithubcomgoogleapisjava-shared-configcomparev140v150-2022-06-10)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.4.0...v1.5.0)

##### Features

-   add build scripts for native image testing in Java 17 ([#&#8203;1440](https://togithub.com/googleapis/java-shared-config/issues/1440)) ([#&#8203;475](https://togithub.com/googleapis/java-shared-config/issues/475)) ([e4dfc1b](https://togithub.com/googleapis/java-shared-config/commit/e4dfc1ba29295158c78c8fcf94467d2a6a33538a))
-   to produce Java 8 compatible bytecode when using JDK 9+ ([2468276](https://togithub.com/googleapis/java-shared-config/commit/2468276145cdfe1ca911b52f765e026e77661a09))

##### Dependencies

-   update surefire.version to v3.0.0-m7 ([bbfe663](https://togithub.com/googleapis/java-shared-config/commit/bbfe66393af3e49612c9c1e4334ba39c133ea1d0))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-live-stream).
github-actions bot pushed a commit that referenced this pull request Jun 30, 2022
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
…-info-reports-plugin to v3.4.0 (#58)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-stitcher).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
…ect resource references that used them (#58)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 459444490

Source-Link: googleapis/googleapis@24f0736

Source-Link: googleapis/googleapis-gen@cd5440b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2Q1NDQwYmEwZWVkMGZjODZiYzNhNTEwYmE1YTFkZmJhODJjODJiMCJ9
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


## [0.5.0](googleapis/java-certificate-manager@v0.4.1...v0.5.0) (2022-08-05)


### ⚠ BREAKING CHANGES

* Removed resource definition of Compute API resources and incorrect resource references that used them (#58)

### Bug Fixes

* Removed resource definition of Compute API resources and incorrect resource references that used them ([#58](googleapis/java-certificate-manager#58)) ([f9bbbca](googleapis/java-certificate-manager@f9bbbca))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#66](googleapis/java-certificate-manager#66)) ([3306e4f](googleapis/java-certificate-manager@3306e4f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


## [0.3.2](googleapis/java-bare-metal-solution@v0.3.1...v0.3.2) (2022-08-09)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#54](googleapis/java-bare-metal-solution#54)) ([e838346](googleapis/java-bare-metal-solution@e838346))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#57](googleapis/java-bare-metal-solution#57)) ([0b12a05](googleapis/java-bare-metal-solution@0b12a05))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


## [0.3.1](googleapis/java-run@v0.3.0...v0.3.1) (2022-08-02)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-run/issues/1485)) ([#57](googleapis/java-run#57)) ([f89997b](googleapis/java-run@f89997b))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#62](googleapis/java-run#62)) ([ca4fde1](googleapis/java-run@ca4fde1))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release *beep* *boop*
---


## [0.2.4](googleapis/java-gke-multi-cloud@v0.2.3...v0.2.4) (2022-09-15)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#57](googleapis/java-gke-multi-cloud#57)) ([561802a](googleapis/java-gke-multi-cloud@561802a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
🤖 I have created a release *beep* *boop*
---


## [0.3.1](https://togithub.com/googleapis/java-apigee-registry/compare/v0.3.0...v0.3.1) (2022-10-03)


### Bug Fixes

* Additional error codes added to service configuration for retry ([#39](https://togithub.com/googleapis/java-apigee-registry/issues/39)) ([55a9b41](https://togithub.com/googleapis/java-apigee-registry/commit/55a9b417cf04575d2070ad026e5648a494fe076a))


### Dependencies

* Update dependency certifi to v2022.9.24 ([#48](https://togithub.com/googleapis/java-apigee-registry/issues/48)) ([1c6ae70](https://togithub.com/googleapis/java-apigee-registry/commit/1c6ae70cb9ff9e7e98d83ce472ae5526d08f9a35))
* Update dependency charset-normalizer to v2.1.1 ([#53](https://togithub.com/googleapis/java-apigee-registry/issues/53)) ([2130079](https://togithub.com/googleapis/java-apigee-registry/commit/21300793a908ed41c535813ee15ec94b5f5ef018))
* Update dependency click to v8.1.3 ([#54](https://togithub.com/googleapis/java-apigee-registry/issues/54)) ([cf3458b](https://togithub.com/googleapis/java-apigee-registry/commit/cf3458bd2972f3db75c8cbf834be0b383d9e74a0))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#42](https://togithub.com/googleapis/java-apigee-registry/issues/42)) ([38cb4f9](https://togithub.com/googleapis/java-apigee-registry/commit/38cb4f9932c3d6cb4c36d3f61922fd613409607f))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#44](https://togithub.com/googleapis/java-apigee-registry/issues/44)) ([ddaed09](https://togithub.com/googleapis/java-apigee-registry/commit/ddaed0964ae57cd7b799b9acf7b202595af4c781))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#65](https://togithub.com/googleapis/java-apigee-registry/issues/65)) ([882e36b](https://togithub.com/googleapis/java-apigee-registry/commit/882e36b2d21ff601f569aa79dfe840cd41bf0438))
* Update dependency gcp-releasetool to v1.8.8 ([#49](https://togithub.com/googleapis/java-apigee-registry/issues/49)) ([3a927a3](https://togithub.com/googleapis/java-apigee-registry/commit/3a927a3df5a8cf5cfff79faede5387291a3d443e))
* Update dependency google-api-core to v2.10.1 ([#55](https://togithub.com/googleapis/java-apigee-registry/issues/55)) ([f841a07](https://togithub.com/googleapis/java-apigee-registry/commit/f841a07c0b1c2fa585f7e665208d6a6b7843c75c))
* Update dependency google-auth to v2.11.1 ([#50](https://togithub.com/googleapis/java-apigee-registry/issues/50)) ([7b450cb](https://togithub.com/googleapis/java-apigee-registry/commit/7b450cbeadc08b8dc26fbd4738ce47788a5cf330))
* Update dependency google-cloud-core to v2.3.2 ([#51](https://togithub.com/googleapis/java-apigee-registry/issues/51)) ([b7f1110](https://togithub.com/googleapis/java-apigee-registry/commit/b7f111014416ff76fa787085d0d0bc9ab47f9af6))
* Update dependency google-cloud-storage to v2.5.0 ([#56](https://togithub.com/googleapis/java-apigee-registry/issues/56)) ([f3799d3](https://togithub.com/googleapis/java-apigee-registry/commit/f3799d3d2d754ec89c784655d835ecaed4df3406))
* Update dependency google-crc32c to v1.5.0 ([#57](https://togithub.com/googleapis/java-apigee-registry/issues/57)) ([b978c7d](https://togithub.com/googleapis/java-apigee-registry/commit/b978c7d2bed23554998a9f0f047e7211ff37f906))
* Update dependency googleapis-common-protos to v1.56.4 ([#52](https://togithub.com/googleapis/java-apigee-registry/issues/52)) ([9e069f1](https://togithub.com/googleapis/java-apigee-registry/commit/9e069f1d96c78fdaedbf57a95d05ada18d57ea0f))
* Update dependency importlib-metadata to v4.12.0 ([#58](https://togithub.com/googleapis/java-apigee-registry/issues/58)) ([370bd1e](https://togithub.com/googleapis/java-apigee-registry/commit/370bd1eba82d820fe7156c276ee5e4a5cbf3f9e0))
* Update dependency jeepney to v0.8.0 ([#59](https://togithub.com/googleapis/java-apigee-registry/issues/59)) ([7a63034](https://togithub.com/googleapis/java-apigee-registry/commit/7a63034a2a194feed6dc7e8215c5063ad1454072))
* Update dependency jinja2 to v3.1.2 ([#60](https://togithub.com/googleapis/java-apigee-registry/issues/60)) ([4fe2b85](https://togithub.com/googleapis/java-apigee-registry/commit/4fe2b853af3c39d2c46efbdc5027cc34945a736c))
* Update dependency keyring to v23.9.3 ([#61](https://togithub.com/googleapis/java-apigee-registry/issues/61)) ([c8cf1c2](https://togithub.com/googleapis/java-apigee-registry/commit/c8cf1c29cab75b18ab67e372bf3d50b36a4b57e9))
* Update dependency markupsafe to v2.1.1 ([#62](https://togithub.com/googleapis/java-apigee-registry/issues/62)) ([98036ae](https://togithub.com/googleapis/java-apigee-registry/commit/98036ae98fa56eba73cccb88a2af726d20fb2a1d))
* Update dependency protobuf to v3.20.2 ([#63](https://togithub.com/googleapis/java-apigee-registry/issues/63)) ([aa9f0e7](https://togithub.com/googleapis/java-apigee-registry/commit/aa9f0e7cad3940fa02cd69c3b3c3e8c2938e0c1b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants