Add ImageInfo, ImageId and test classes #794

mziccard · 2016-03-26T00:49:52Z

This PR adds ImageId, ImageInfo and related test classes.
Images can be deprecated using deprecate by passing a DeprecationStatus object.
This PR also refactors DeprecationStatus to add a public builder.

Following issue #732 this PR also makes DeprecationStatus more tolerant in parsing timestamps (also partial timestamps are supported now).
However as per #732 no checks are made on deleted, deprecated and obsolete timestamps provided to deprecate. If a user misused such fields, creating a DeprecationStatus might fail. Should we make deleted, deprecated and obsolete of String type? Or keep them of Long type and set them to null if the string value is not parsable?

coveralls · 2016-03-26T00:55:55Z

Coverage increased (+0.3%) to 82.529% when pulling 0149feb on mziccard:compute-image into 32394d2 on GoogleCloudPlatform:compute-alpha.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DeprecationStatus.java

+      return this;
+    }
+
+    public Builder<T> status(Status status) {


ajkannan · 2016-03-28T20:46:24Z

Question about the deprecation status: the dates a user inputs in those fields don't cause any behavioral changes on the server, do they? If a user passes in valid dates in the proper format, does the service move the deprecation status automatically for the user from DEPRECATED to OBSOLETE, for example? Alternatively, does the user manually have to send a request to update the deprecation status? I imagine it's the latter because the service would encounter errors if the service doesn't input-validate these fields.

Would the following proposal work?

Provide getters for the 3 timestamp fields as strings (and represent them internally as strings) so that the user can see the values. Also this way the user won't unset the fields if they were set to non-parseable (but potentially informative) fields .
Provide (or document) a method to convert the strings to longs. We could also provide getters for each as longs, but this might be a lot of methods.
Only provide setters for those 3 fields as longs.

gcloud-java-compute/src/test/java/com/google/gcloud/compute/DiskImageConfigurationTest.java

+  @Test
+  public void testToBuilder() {
+    compareDiskImageConfiguration(CONFIGURATION, CONFIGURATION.toBuilder().build());
+    DiskId newDisk = DiskId.of("newProjet", "newZone", "newDisk");


mziccard · 2016-03-28T22:33:21Z

The dates a user inputs in those fields don't cause any behavioral changes on the server, do they?

Dates have no impact on the service. I think that what you suggest makes sense. I would also add a getter for each timestamp that returns the long timestamp:

public String deprecated();
public Long deprecatedTimestamp();

I agree that setters should only take long. I also think that getters for Long values should be permissive and parse even partial timestamps.

aozarov · 2016-03-28T23:04:17Z

I agree that setters should only take long. I also think that getters for Long values should be permissive and parse even partial timestamps.

If I understand the issue correctly the timestamp in this case is merely a label (open text supplied by the user) with a recommended convention for the value.

If so, honestly I am not sure why the service API even bothered with proving a specific setting for it (as oppose to providing a way to specify any set of attributes) and in this case would not bother in trying
to parse it. I think the sometimes work sometimes does not is not ideal.

ajkannan · 2016-03-28T23:31:01Z

@mziccard Is the input validation an issue for deprecation statuses for other types of compute resources, or just for images?

@aozarov's point about having methods that sometimes work and sometimes don't makes me rethink my proposal and instead side with your string proposal.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/RawImageConfiguration.java

+     * {@code gs://bucket/file}).
+     */
+    public Builder source(String source) {
+      this.source = source;


ajkannan · 2016-03-28T23:42:33Z

Done with my pass.

mziccard · 2016-03-29T08:26:09Z

If I understand the issue correctly the timestamp in this case is merely a label (open text supplied by the user) with a recommended convention for the value.

Yes but I don't think this was intended but rather a missing check on the service's side. If you look at the docs for image.deprecate it seems to me that the RFC format is not intended to be just a suggestion. DeprecationStatus is also used for disk types, machine types, regions and zones and there all timestamps have the expected format.

coveralls · 2016-03-29T13:54:35Z

Coverage increased (+0.3%) to 82.489% when pulling 22e51f4 on mziccard:compute-image into 32394d2 on GoogleCloudPlatform:compute-alpha.

mziccard · 2016-03-29T14:11:38Z

I fixed all comments but the ones on DeprecationStatus timestamps as discussion is still open

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DeprecationStatus.java

+  /**
+   * Returns a builder for the {@code DeprecationStatus} object.
+   */
+  public Builder<T> toBuilder() {


mziccard · 2016-03-29T19:18:02Z

I add String setters/getters to DeprecationStatus and updated the tests. Let me know how you like it!

aozarov · 2016-03-29T23:36:06Z

Looks good. I think there few comments we need to address before we can merge.

coveralls · 2016-03-30T10:20:42Z

Coverage increased (+0.4%) to 82.58% when pulling 562324a on mziccard:compute-image into 32394d2 on GoogleCloudPlatform:compute-alpha.

mziccard · 2016-03-30T14:54:26Z

Comments should be fixed now (but the one concerning sourceDisk and sourceDiskId):

DeprecationStatus timestamp getters now throw IllegalStateException
Move archiveSizeBytes to ImageConfiguration
Add Type enum to ImageConfiguration and type field
Rename RawImageConfiguration to ComputeImageConfiguration
Update tests
Add getClass() equality check to ImageConfiguration.baseEquals

gcloud-java-compute/src/main/java/com/google/gcloud/compute/ImageInfo.java

@@ -393,7 +393,7 @@ Image toPb() {
  /**
   * Returns a builder for an {@code ImageInfo} object given the image identity and an image
   * configuration. Use {@link DiskImageConfiguration} to create an image from an existing disk. Use
-   * {@link RawImageConfiguration} to create an image from a raw image stored in Google Cloud
+   * {@link StorageImageConfiguration} to create an image from a raw image stored in Google Cloud


aozarov · 2016-03-31T02:55:33Z

Looks good! Few javadoc related fixes (IlegalArgumentException) and question/suggestions.
Feel free to squash and merge after you fix them.

- Add public builder and factory methods to DeprecationStatus - Add setters/getters for DeprecationStatus timestamps as String - Add ImageId, configuration classes and ImageInfo class

gcloud-java-compute/src/test/java/com/google/gcloud/compute/DeprecationStatusTest.java

+    assertEquals("delete", deprecationStatus.deleted());
+    try {
+      deprecationStatus.deletedMillis();
+      fail("Expected IllegalArgumentException");


coveralls · 2016-03-31T06:55:25Z

Coverage increased (+0.4%) to 82.58% when pulling f2231c6 on mziccard:compute-image into 32394d2 on GoogleCloudPlatform:compute-alpha.

…to v2.5.2 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-kms-bom](https://togithub.com/googleapis/java-kms) | `2.5.1` -> `2.5.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/compatibility-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-kms-bom/2.5.2/confidence-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-kms).

…is#794) * feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: fix deps Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu1995 <neenushaji@google.com>

…oogleapis#794) * fix!: remove Application and Profile services and and related protos, enums, and messages PiperOrigin-RevId: 453241222 Source-Link: googleapis/googleapis@7837470 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae2c052743706161ac95adc5048ad5a3de8a6585 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWUyYzA1Mjc0MzcwNjE2MWFjOTVhZGM1MDQ4YWQ1YTNkZThhNjU4NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Integrate new gapic-generator-java and rules_gapic PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update pom.xml * fix: update gapic-generator-java with mock service generation fixes PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [1.5.0](googleapis/java-resourcemanager@v1.4.0...v1.5.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#794](googleapis/java-resourcemanager#794)) ([d732072](googleapis/java-resourcemanager@d732072)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#796](googleapis/java-resourcemanager#796)) ([9f2a86e](googleapis/java-resourcemanager@9f2a86e)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#793](googleapis/java-resourcemanager#793)) ([edfaad3](googleapis/java-resourcemanager@edfaad3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.4.0](googleapis/java-talent@v2.3.0...v2.4.0) (2022-07-01) ### Features * Add a new operator on companyDisplayNames filter to further support fuzzy match by treating input value as a multi word token ([googleapis#788](googleapis/java-talent#788)) ([1460184](googleapis/java-talent@1460184)) * Add a new option TELECOMMUTE_JOBS_EXCLUDED under enum TelecommutePreference to completely filter out the telecommute jobs in response ([1460184](googleapis/java-talent@1460184)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#794](googleapis/java-talent#794)) ([d2e17f0](googleapis/java-talent@d2e17f0)) ### Documentation * Deprecate option TELECOMMUTE_EXCLUDED under enum TelecommutePreference ([1460184](googleapis/java-talent@1460184)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#797](googleapis/java-talent#797)) ([3e61e7f](googleapis/java-talent@3e61e7f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…r to v2.3.2 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-scheduler](https://togithub.com/googleapis/java-scheduler) | `2.3.0` -> `2.3.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/compatibility-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-scheduler/2.3.2/confidence-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-scheduler).

🤖 I have created a release *beep* *boop* --- ## [2.4.4](googleapis/java-accessapproval@v2.4.3...v2.4.4) (2022-08-18) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#793](googleapis/java-accessapproval#793)) ([5cb6e8f](googleapis/java-accessapproval@5cb6e8f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…eech to v2.4.9 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-texttospeech](https://togithub.com/googleapis/java-texttospeech) | `2.4.8` -> `2.4.9` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/compatibility-slim/2.4.8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-texttospeech/2.4.9/confidence-slim/2.4.8)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-texttospeech).

…1.4 (#794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-websecurityscanner).

🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-core@v2.5.11...v2.6.0) (2022-04-14) ### Features * **java:** remove GoogleJsonClentFeature and OpenCensusFeature after relocation ([#793](googleapis/java-core#793)) ([cafd489](googleapis/java-core@cafd489)) * **java:** remove Netty Native Image configuration after relocation to gax ([#771](googleapis/java-core#771)) ([9cc7dba](googleapis/java-core@9cc7dba)) * **java:** remove protobuf Native Image configuration ([#784](googleapis/java-core#784)) ([7a8df66](googleapis/java-core@7a8df66)) * remove native-image.properties settings after relocation ([#794](googleapis/java-core#794)) ([219a519](googleapis/java-core@219a519)) * remove resource-config after relocation ([#795](googleapis/java-core#795)) ([8ed3110](googleapis/java-core@8ed3110)) * remove substitutions after relocation to gax ([#789](googleapis/java-core#789)) ([85280b1](googleapis/java-core@85280b1)) ### Bug Fixes * **java:** register test class for reflection to fix native image test ([#766](googleapis/java-core#766)) ([fa07125](googleapis/java-core@fa07125)) ### Dependencies * revert protobuf to 3.19 and common-protos 2.8.3 ([#798](googleapis/java-core#798)) ([27ca70c](googleapis/java-core@27ca70c)) * update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#800](googleapis/java-core#800)) ([3abc47d](googleapis/java-core@3abc47d)) * update dependency com.google.api:gax-bom to v2.16.0 ([#785](googleapis/java-core#785)) ([bd33a76](googleapis/java-core@bd33a76)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.1 ([#792](googleapis/java-core#792)) ([3f85e62](googleapis/java-core@3f85e62)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.2 ([#796](googleapis/java-core#796)) ([d6ea18e](googleapis/java-core@d6ea18e)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.0 ([#783](googleapis/java-core#783)) ([48594f3](googleapis/java-core@48594f3)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.1 ([#799](googleapis/java-core#799)) ([9fe7d35](googleapis/java-core@9fe7d35)) * update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#788](googleapis/java-core#788)) ([cfdabb4](googleapis/java-core@cfdabb4)) * update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#791](googleapis/java-core#791)) ([d9ff405](googleapis/java-core@d9ff405)) * update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#797](googleapis/java-core#797)) ([dfc3c57](googleapis/java-core@dfc3c57)) * update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#787](googleapis/java-core#787)) ([51f59fc](googleapis/java-core@51f59fc)) * update dependency io.grpc:grpc-bom to v1.45.1 ([#780](googleapis/java-core#780)) ([cd8a078](googleapis/java-core@cd8a078)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added the api: compute Issues related to the Compute Engine API. label Mar 26, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2016

ajkannan reviewed Mar 28, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DeprecationStatus.java

return this;

}

public Builder<T> status(Status status) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ajkannan reviewed Mar 28, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/RawImageConfiguration.java

* {@code gs://bucket/file}).

*/

public Builder source(String source) {

this.source = source;

This comment was marked as spam.

Sign in to view

ajkannan reviewed Mar 29, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DeprecationStatus.java

/**

* Returns a builder for the {@code DeprecationStatus} object.

*/

public Builder<T> toBuilder() {

This comment was marked as spam.

Sign in to view

aozarov reviewed Mar 31, 2016
View reviewed changes

Add ImageInfo and related non-functional classes

f2231c6

- Add public builder and factory methods to DeprecationStatus - Add setters/getters for DeprecationStatus timestamps as String - Add ImageId, configuration classes and ImageInfo class

mziccard force-pushed the compute-image branch from 2f70f1f to f2231c6 Compare March 31, 2016 06:50

mziccard reviewed Mar 31, 2016
View reviewed changes

gcloud-java-compute/src/test/java/com/google/gcloud/compute/DeprecationStatusTest.java

assertEquals("delete", deprecationStatus.deleted());

try {

deprecationStatus.deletedMillis();

fail("Expected IllegalArgumentException");

This comment was marked as spam.

Sign in to view

mziccard merged commit bc368cc into googleapis:compute-alpha Mar 31, 2016

suztomo pushed a commit that referenced this pull request Feb 1, 2023

feat: remove native-image.properties settings after relocation (#794)

219a519

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ImageInfo, ImageId and test classes #794

Add ImageInfo, ImageId and test classes #794

mziccard commented Mar 26, 2016

coveralls commented Mar 26, 2016

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Mar 28, 2016

This comment was marked as spam.

mziccard commented Mar 28, 2016

aozarov commented Mar 28, 2016

ajkannan commented Mar 28, 2016

This comment was marked as spam.

ajkannan commented Mar 28, 2016

mziccard commented Mar 29, 2016

coveralls commented Mar 29, 2016

mziccard commented Mar 29, 2016

This comment was marked as spam.

mziccard commented Mar 29, 2016

aozarov commented Mar 29, 2016

coveralls commented Mar 30, 2016

mziccard commented Mar 30, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 31, 2016

This comment was marked as spam.

coveralls commented Mar 31, 2016

Add ImageInfo, ImageId and test classes #794

Add ImageInfo, ImageId and test classes #794

Conversation

mziccard commented Mar 26, 2016

coveralls commented Mar 26, 2016

This comment was marked as spam.

This comment was marked as spam.

ajkannan commented Mar 28, 2016

This comment was marked as spam.

mziccard commented Mar 28, 2016

aozarov commented Mar 28, 2016

ajkannan commented Mar 28, 2016

This comment was marked as spam.

ajkannan commented Mar 28, 2016

mziccard commented Mar 29, 2016

coveralls commented Mar 29, 2016

mziccard commented Mar 29, 2016

This comment was marked as spam.

mziccard commented Mar 29, 2016

aozarov commented Mar 29, 2016

coveralls commented Mar 30, 2016

mziccard commented Mar 30, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 31, 2016

This comment was marked as spam.

coveralls commented Mar 31, 2016