Clean up LocalGcdHelper and docs #821

ajkannan · 2016-03-30T01:44:36Z

Adds an options method to LocalGcdHelper to make it more consistent with other test helpers.
Uses the options method in DatastoreTest
Updates the package info and TESTING docs to reflect the recently-added consistency setting
Allows consistency to be set from command line invocation of LocalGcdHelper

Update: This PR went through different iterations/discussions, and some of the original bullet points and comments below no longer apply. Here is a final summary of changes:

Renamed LocalGcdHelper and RemoteGcsHelper to LocalDatastoreHelper and RemoteStorageHelper
Made LocalDatastoreHelper creation/startup more consistent with other test helpers
Removed the LocalDatastoreHelper command line interface
Updated the version of gcd.sh used.

coveralls · 2016-03-30T02:23:02Z

Coverage decreased (-0.02%) to 85.563% when pulling e7994eb on ajkannan:cleanup-localgcdhelper into 6747274 on GoogleCloudPlatform:master.

ajkannan · 2016-03-30T02:45:25Z

Will add a commit tomorrow to change the name of LocalGcdHelper to LocalDatastoreHelper to be more consistent with other libraries, as per @aozarov's suggestion.

TESTING.md

+  - Run `LocalGcdHelper.java`'s `main` method with `START` provided as an argument, followed by optional arguments `--port=<port number>` and `--consistency=<float between 0 and 1, inclusive>`.  This will create a temporary folder on your computer and bind `localhost:<port number>` for communication with the local datastore.  If no port number is specified, port 8080 will be used.  The consistency setting controls the fraction of Datastore writes that are immediately visible in global queries.
+  - Use the `LocalGcdHelper.start(String projectId, int port, double consistency)` method before running your tests. For example, you can use the following code to start the local Datastore on any available port with the consistency set to 0.9:
+    ```java
+    int port = LocalGcdHelper.findAvailablePort(LocalGcdHelper.DEFAULT_PORT);


coveralls · 2016-03-31T02:13:04Z

Coverage increased (+0.3%) to 85.9% when pulling 7edd544 on ajkannan:cleanup-localgcdhelper into a248465 on GoogleCloudPlatform:master.

ajkannan · 2016-03-31T02:13:12Z

Added a commit to:

Rename LocalGcdHelper --> LocalDatastoreHelper and RemoteGcsHelper --> RemoteStorageHelper.
Update TESTING docs, pkg-infos, and references to LocalGcdHelper/RemoteGcsHelper in javadoc.
Remove main-related functions from LocalDatastoreHelper.
Automatically choose a port for the user

coveralls · 2016-03-31T02:17:24Z

Coverage increased (+0.3%) to 85.9% when pulling 7edd544 on ajkannan:cleanup-localgcdhelper into a248465 on GoogleCloudPlatform:master.

TESTING.md

-  - Call `LocalGcdHelper.start(<project ID>, <port number>)` before running your tests.  Save the `LocalGcdHelper` object returned so that you can stop the emulator later.
+1. Start the local Datastore emulator before running your tests using `LocalDatastoreHelper`'s `start` method. This will create a temporary folder on your computer and bind a port for communication with the local datastore. There are two optional arguments for `start`: project ID and consistency. The consistency setting controls the fraction of Datastore writes that are immediately visible in global queries.
+  ```java
+  // Use defaults for project ID and consistency


coveralls · 2016-03-31T21:31:32Z

Coverage increased (+0.3%) to 85.827% when pulling 0417c42 on ajkannan:cleanup-localgcdhelper into 4b1a4fd on GoogleCloudPlatform:master.

coveralls · 2016-03-31T21:33:24Z

Coverage increased (+0.3%) to 85.827% when pulling 0417c42 on ajkannan:cleanup-localgcdhelper into 4b1a4fd on GoogleCloudPlatform:master.

ajkannan · 2016-03-31T22:02:58Z

Added a commit to address comments, ready for another pass.

TESTING.md

  ```java
  Datastore localDatastore = helper.options().service();
  ```

+  Note that you must call `start` before `options()`; otherwise, you will see an `IOException` regarding a refused connection.


...d-java-datastore/src/main/java/com/google/gcloud/datastore/testing/LocalDatastoreHelper.java

+   */
+  public void start() throws IOException, InterruptedException {
+    // send a quick request in case we have a hanging process from a previous run
+    checkArgument(consistency >= 0.0 && consistency <= 1.0, "Consistency must be between 0 and 1");


aozarov · 2016-04-08T03:36:43Z

Looks good. Few comments. Feel free to merge after considering them.

coveralls · 2016-04-08T16:16:35Z

Changes Unknown when pulling 7fe981d on ajkannan:cleanup-localgcdhelper into * on GoogleCloudPlatform:master*.

...d-java-datastore/src/main/java/com/google/gcloud/datastore/testing/LocalDatastoreHelper.java

-      return defaultPort;
-    }
-  }
-
  private static Path installedGcdPath() {


gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/LocalDatastoreHelperTest.java

+public class LocalDatastoreHelperTest {
+
+  private static final double TOLERANCE = 0.00001;
+  private static final String PROJECT_ID_PREFIX = "test-project-";


- [ ] Regenerate this pull request now. PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: googleapis/googleapis-gen@4ca52a5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9

…21.2 (googleapis#821) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-java-util](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.1` -> `3.21.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/compatibility-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/confidence-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog).

🤖 I have created a release *beep* *boop* --- ## [1.8.4](googleapis/java-datacatalog@v1.8.3...v1.8.4) (2022-06-27) ### Dependencies * update dependency com.google.protobuf:protobuf-java-util to v3.21.2 ([googleapis#821](googleapis/java-datacatalog#821)) ([48696fb](googleapis/java-datacatalog@48696fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

… v2.3.0 (#821) * chore(deps): update dependency com.google.cloud:google-cloud-trace to v2.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…1.0 (#821) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/compatibility-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/confidence-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).

…om to v2.4.2 (#821) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-talent-bom](https://togithub.com/googleapis/java-talent) | `2.4.0` -> `2.4.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.2/compatibility-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.2/confidence-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-talent).

…1.1 (#821) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-secretmanager).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

… to v1.41.8 (#821) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.http-client:google-http-client-bom](https://togithub.com/googleapis/google-http-java-client) | `1.41.7` -> `1.41.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.http-client:google-http-client-bom/1.41.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.http-client:google-http-client-bom/1.41.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.http-client:google-http-client-bom/1.41.8/compatibility-slim/1.41.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.http-client:google-http-client-bom/1.41.8/confidence-slim/1.41.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/google-http-java-client</summary> ### [`v1.41.8`](https://togithub.com/googleapis/google-http-java-client/releases/v1.41.8) [Compare Source](https://togithub.com/googleapis/google-http-java-client/compare/v1.41.7...v1.41.8) ##### [1.41.8](https://togithub.com/googleapis/google-http-java-client/compare/v1.41.7...v1.41.8) (2022-04-29) ##### Dependencies - downgrade appengine to 1.9.X ([#1645](https://togithub.com/googleapis/google-http-java-client/issues/1645)) ([da9dd8b](https://togithub.com/googleapis/google-http-java-client/commit/da9dd8bca97cc10712ce24054d2edd3d5ac2e571)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.7.0](googleapis/java-core@v2.6.1...v2.7.0) (2022-05-18) ### Features * **java:** remove native-image-support module ([#820](googleapis/java-core#820)) ([b827e0a](googleapis/java-core@b827e0a)) * next release from main branch is 2.7.0 ([#807](googleapis/java-core#807)) ([2145212](googleapis/java-core@2145212)) ### Bug Fixes * remove native-image-support module from version.txt ([#822](googleapis/java-core#822)) ([8285eee](googleapis/java-core@8285eee)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#823](googleapis/java-core#823)) ([58aac09](googleapis/java-core@58aac09)) * update dependency com.google.api:api-common to v2.2.0 ([#827](googleapis/java-core#827)) ([fa4a5db](googleapis/java-core@fa4a5db)) * update dependency com.google.api:gax-bom to v2.17.0 ([#826](googleapis/java-core#826)) ([d1d886d](googleapis/java-core@d1d886d)) * update dependency com.google.api:gax-bom to v2.18.0 ([#829](googleapis/java-core#829)) ([355dd4a](googleapis/java-core@355dd4a)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.2 ([#805](googleapis/java-core#805)) ([c5b4893](googleapis/java-core@c5b4893)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.3 ([#814](googleapis/java-core#814)) ([9621659](googleapis/java-core@9621659)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.4 ([#825](googleapis/java-core#825)) ([8f907db](googleapis/java-core@8f907db)) * update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#828](googleapis/java-core#828)) ([0e53f0c](googleapis/java-core@0e53f0c)) * update dependency com.google.cloud:native-image-support to v0.14.0 ([#824](googleapis/java-core#824)) ([bbeb567](googleapis/java-core@bbeb567)) * update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#806](googleapis/java-core#806)) ([c4d3e17](googleapis/java-core@c4d3e17)) * update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#821](googleapis/java-core#821)) ([8c747e1](googleapis/java-core@8c747e1)) * update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#813](googleapis/java-core#813)) ([f259b41](googleapis/java-core@f259b41)) * update dependency io.grpc:grpc-bom to v1.46.0 ([#815](googleapis/java-core#815)) ([2dc7507](googleapis/java-core@2dc7507)) * update opencensus.version to v0.31.1 ([#819](googleapis/java-core#819)) ([96982b0](googleapis/java-core@96982b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [googleapis-common-protos](https://togithub.com/googleapis/python-api-common-protos) | `==1.56.3` -> `==1.56.4` | [![age](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/compatibility-slim/1.56.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/confidence-slim/1.56.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).

Source-Link: googleapis/googleapis@761c3cb Source-Link: googleapis/googleapis-gen@cac56a0 Copy-Tag: eyJwIjoiamF2YS1jb21wdXRlLy5Pd2xCb3QueWFtbCIsImgiOiJjYWM1NmEwZWRkMTE3OWU5MjljMzFlYmVhYWU4NDg3ZjM4OGRjMTA5In0=

…#9628) * feat: Update Compute Engine API to revision 20230701 (#821) Source-Link: googleapis/googleapis@761c3cb Source-Link: googleapis/googleapis-gen@cac56a0 Copy-Tag: eyJwIjoiamF2YS1jb21wdXRlLy5Pd2xCb3QueWFtbCIsImgiOiJjYWM1NmEwZWRkMTE3OWU5MjljMzFlYmVhYWU4NDg3ZjM4OGRjMTA5In0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

ajkannan added api: datastore Issues related to the Datastore API. docs type: cleanup An internal cleanup or hygiene concern. labels Mar 30, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2016

ajkannan force-pushed the cleanup-localgcdhelper branch 2 times, most recently from dac0698 to e7994eb Compare March 30, 2016 02:17

aozarov reviewed Mar 30, 2016
View reviewed changes

ajkannan force-pushed the cleanup-localgcdhelper branch from 8ecd043 to 7edd544 Compare March 31, 2016 02:08

mziccard reviewed Mar 31, 2016
View reviewed changes

ajkannan force-pushed the cleanup-localgcdhelper branch 3 times, most recently from 577458f to 0417c42 Compare March 31, 2016 21:27

mziccard reviewed Apr 1, 2016
View reviewed changes

TESTING.md

```java

Datastore localDatastore = helper.options().service();

```

Note that you must call `start` before `options()`; otherwise, you will see an `IOException` regarding a refused connection.

This comment was marked as spam.

Sign in to view

aozarov reviewed Apr 8, 2016
View reviewed changes

Minor changes

7fe981d

mziccard reviewed Apr 8, 2016
View reviewed changes

...d-java-datastore/src/main/java/com/google/gcloud/datastore/testing/LocalDatastoreHelper.java

return defaultPort;

}

}

private static Path installedGcdPath() {

This comment was marked as spam.

Sign in to view

ajkannan merged commit 53a60d1 into googleapis:master Apr 8, 2016

ajkannan deleted the cleanup-localgcdhelper branch April 8, 2016 16:20

aozarov reviewed Apr 8, 2016
View reviewed changes

release-please bot mentioned this pull request Jul 10, 2023

chore(main): release 1.15.0 #9581

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up LocalGcdHelper and docs #821

Clean up LocalGcdHelper and docs #821

ajkannan commented Mar 30, 2016

coveralls commented Mar 30, 2016

ajkannan commented Mar 30, 2016

This comment was marked as spam.

coveralls commented Mar 31, 2016

ajkannan commented Mar 31, 2016

coveralls commented Mar 31, 2016

This comment was marked as spam.

coveralls commented Mar 31, 2016

coveralls commented Mar 31, 2016

ajkannan commented Mar 31, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 8, 2016

coveralls commented Apr 8, 2016

This comment was marked as spam.

This comment was marked as spam.

Clean up LocalGcdHelper and docs #821

Clean up LocalGcdHelper and docs #821

Conversation

ajkannan commented Mar 30, 2016

coveralls commented Mar 30, 2016

ajkannan commented Mar 30, 2016

This comment was marked as spam.

coveralls commented Mar 31, 2016

ajkannan commented Mar 31, 2016

coveralls commented Mar 31, 2016

This comment was marked as spam.

coveralls commented Mar 31, 2016

coveralls commented Mar 31, 2016

ajkannan commented Mar 31, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 8, 2016

coveralls commented Apr 8, 2016

This comment was marked as spam.

This comment was marked as spam.