Get projectId from gcloud active config #831

mziccard · 2016-03-31T22:32:51Z

This addresses the first part of #827: "Wrong gcloud command configuration is loaded"

coveralls · 2016-03-31T22:40:05Z

Coverage decreased (-0.04%) to 85.471% when pulling 33f740a on mziccard:active-gcloud-project into 4b1a4fd on GoogleCloudPlatform:master.

gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

@@ -381,6 +383,15 @@ protected String defaultProject() {
    return projectId != null ? projectId : googleCloudProjectId();
  }

+  private static String activeGoogleCloudConfig(File configDir) {
+    try {
+      return Files.readFirstLine(new File(configDir, "active_config"), Charset.defaultCharset());


coveralls · 2016-04-01T16:41:33Z

Coverage decreased (-0.05%) to 85.453% when pulling 379a0a8 on mziccard:active-gcloud-project into 4b1a4fd on GoogleCloudPlatform:master.

mziccard · 2016-04-01T16:42:35Z

@aozarov Now the code fallbacks to default if the file is empty.

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…om to v2.4.3 (#831) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-talent-bom](https://togithub.com/googleapis/java-talent) | `2.4.2` -> `2.4.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.3/compatibility-slim/2.4.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-talent-bom/2.4.3/confidence-slim/2.4.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-talent).

…1575) (#831) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

mziccard added the api: core label Mar 31, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2016

aozarov reviewed Mar 31, 2016
View reviewed changes

Get projectId from gcloud active config

379a0a8

mziccard force-pushed the active-gcloud-project branch from 33f740a to 379a0a8 Compare April 1, 2016 16:32

aozarov merged commit 6cbddff into googleapis:master Apr 1, 2016

mziccard mentioned this pull request Apr 4, 2016

Wrong default project ID is chosen when active configuration is not the default or service keys are used #827

Closed

tswast mentioned this pull request Oct 21, 2016

Core: google.cloud._helpers._default_service_project_id() does not use project ID from active configuration googleapis/google-cloud-python#2588

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get projectId from gcloud active config #831

Get projectId from gcloud active config #831

mziccard commented Mar 31, 2016

coveralls commented Mar 31, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 1, 2016

mziccard commented Apr 1, 2016

Get projectId from gcloud active config #831

Get projectId from gcloud active config #831

Conversation

mziccard commented Mar 31, 2016

coveralls commented Mar 31, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 1, 2016

mziccard commented Apr 1, 2016