Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [addressvalidation] new module for addressvalidation #8741

Closed
wants to merge 2 commits into from
Closed

feat: [addressvalidation] new module for addressvalidation #8741

wants to merge 2 commits into from

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Nov 8, 2022 •
edited
Loading

Initial generation for new addressvalidation client library

suztomo
suztomo requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address validation api is not Cloud. I see the artifact ID contains cloud. Can you check the discrepancy?

@alicejli alicejli mentioned this pull request Nov 10, 2022
Closed
@alicejli
Copy link
Contributor Author

Thank you for catching @suztomo! I've regenerated in this PR: #8763; please take a look. I will close this one.

@alicejli alicejli closed this Nov 10, 2022
@alicejli alicejli mentioned this pull request Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alicejli @suztomo