Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [addressvalidation] new module for addressvalidation #8850

Merged

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Nov 29, 2022

Initial generation for new addressvalidation client library

Corrected from #8741 and #8763

Generation script:

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=addressvalidation \
  --proto-path=google/maps/addressvalidation \
  --name-pretty="Address Validation API" \
  --product-docs="https://developers.google.com/maps/documentation/address-validation/" \
  --api-description="The Address Validation API allows developers to verify the accuracy of addresses. Given an address, it returns information about the correctness of the components of the parsed address, a geocode, and a verdict on the deliverability of the parsed address." \
  --api-id=addressvalidation.googleapis.com \
  --cloud-api=false \
  --requires-billing=true \
  --distribution-name="com.google.maps:google-maps-addressvalidation"

@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 29, 2022
@alicejli alicejli marked this pull request as ready for review November 29, 2022 22:17
@ddixit14
Copy link
Contributor

@alicejli this file, mvnDependency.txt looks like a log file. Are you sure this is a part of the new library generated?

Comment on lines +28 to +30
<groupId>com.google.maps</groupId>
<artifactId>google-maps-addressvalidation</artifactId>
<version>0.0.1-SNAPSHOT</version><!-- {x-version-update:google-maps-addressvalidation:current} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven coordinates look good.

@snippet-bot
Copy link

snippet-bot bot commented Nov 30, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@alicejli
Copy link
Contributor Author

@alicejli this file, mvnDependency.txt looks like a log file. Are you sure this is a part of the new library generated?

Good catch! I was debugging something separately and forgot to remove. Removed - thanks!

@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2022
@alicejli alicejli merged commit bde6af5 into googleapis:main Nov 30, 2022
@alicejli alicejli deleted the new_module_java-addressvalidation-2 branch November 30, 2022 16:55
@release-please release-please bot mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants