Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename addressvalidation module to maps-addressvalidation #8880

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Dec 6, 2022

#8850 should have used maps-addressvalidation as the api-short-name / module name to follow maps-routing convention.

@alicejli alicejli changed the title rename addressvalidation module to maps-addressvalidation fix: rename addressvalidation module to maps-addressvalidation Dec 6, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 6, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@suztomo
Copy link
Member

suztomo commented Dec 6, 2022

I see Git recognizes these changes as renames. Good.

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Can you add the command you ran in the description of this pull request.

@alicejli
Copy link
Contributor Author

alicejli commented Dec 6, 2022

Approving. Can you add the command you ran in the description of this pull request.

Thanks Tomo. I manually updated the directory name and IntelliJ automatically updated the file directories (I had to manually update the repo-metadata file).

@alicejli alicejli marked this pull request as ready for review December 6, 2022 19:50
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@alicejli alicejli merged commit 0020df6 into googleapis:main Dec 6, 2022
@release-please release-please bot mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants