Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore: Filter seems not to work on Strings #24

Closed
temsa opened this issue Jul 21, 2014 · 5 comments · Fixed by #26
Closed

datastore: Filter seems not to work on Strings #24

temsa opened this issue Jul 21, 2014 · 5 comments · Fixed by #26
Assignees
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@temsa
Copy link

temsa commented Jul 21, 2014

var q = ds.createQuery('Myobject').filter("state =", "DONE").order("-createdAt").limit(500)

Does not return anything, while removing the filter returns some 'state = DONE' objects

@rakyll
Copy link
Contributor

rakyll commented Jul 21, 2014

Looking at it.

@silvolu, another case for regression tests if we're missing it.

@rakyll rakyll changed the title Filter seems not to work on Strings datastore: Filter seems not to work on Strings Jul 21, 2014
@rakyll rakyll added 0.3.x and removed 0.4.x labels Jul 21, 2014
@rakyll
Copy link
Contributor

rakyll commented Jul 21, 2014

@proppy, I receive no results for the following runQuery request proto, although there is a record. Could it to be related to a missing index?

{
    "readOptions": {
        "transaction": null
    },
    "query": {
        "projection": [],
        "kinds": [{
            "name": "Company"
        }],
        "filter": {
            "compositeFilter": {
                "filters": [{
                    "propertyFilter": {
                        "property": {
                            "name": "name"
                        },
                        "operator": "EQUAL",
                        "value": {
                            "properties": {
                                "stringValue": "Google"
                            }
                        }
                    }
                }],
                "operator": "AND"
            }
        },
        "order": [],
        "groupBy": []
    }
}

@rakyll
Copy link
Contributor

rakyll commented Jul 21, 2014

#26 fixed it, publishing to npm as 0.0.5.

@rakyll
Copy link
Contributor

rakyll commented Jul 21, 2014

gcloud@0.0.5 is now live.

@proppy
Copy link
Contributor

proppy commented Jul 21, 2014

Oh yes, value has no properties attribute, see the doc here: https://developers.google.com/datastore/docs/apis/v1beta2/datasets/runQuery

@jgeewax jgeewax added the api: datastore Issues related to the Datastore API. label Feb 2, 2015
@jgeewax jgeewax modified the milestones: M1: core, datastore & storage, Datastore Stable Feb 2, 2015
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
chingor13 pushed a commit that referenced this issue Sep 12, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^9.2.1` -> `^10.0.0`](https://renovatebot.com/diffs/npm/sinon/9.2.4/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/compatibility-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/confidence-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v10.0.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#&#8203;1000--2021-03-22)

[Compare Source](https://togithub.com/sinonjs/sinon/compare/v9.2.4...v10.0.0)

==================

-   Upgrade nise to 4.1.0
-   Use [@&#8203;sinonjs/eslint-config](https://togithub.com/sinonjs/eslint-config)[@&#8203;4](https://togithub.com/4) => Adopts ES2017 => Drops support for IE 11, Legacy Edge and legacy Safari

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-artifact-registry).
chingor13 pushed a commit that referenced this issue Sep 14, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^9.2.1` -> `^10.0.0`](https://renovatebot.com/diffs/npm/sinon/9.2.4/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/compatibility-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/confidence-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v10.0.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#&#8203;1000--2021-03-22)

[Compare Source](https://togithub.com/sinonjs/sinon/compare/v9.2.4...v10.0.0)

==================

-   Upgrade nise to 4.1.0
-   Use [@&#8203;sinonjs/eslint-config](https://togithub.com/sinonjs/eslint-config)[@&#8203;4](https://togithub.com/4) => Adopts ES2017 => Drops support for IE 11, Legacy Edge and legacy Safari

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-artifact-registry).
sofisl pushed a commit that referenced this issue Sep 16, 2022
sofisl pushed a commit that referenced this issue Sep 27, 2022
sofisl pushed a commit that referenced this issue Oct 5, 2022
sofisl pushed a commit that referenced this issue Oct 8, 2022
sofisl pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 11, 2022
sofisl pushed a commit that referenced this issue Nov 11, 2022
…ript generator. (#24)

Also removing the explicit generator tag for the IAMPolicy mixin for the kms and pubsub APIS as the generator will now read it from the .yaml file.

PiperOrigin-RevId: 385101839

Source-Link: googleapis/googleapis@80f4042

Source-Link: googleapis/googleapis-gen@d3509d2
sofisl pushed a commit that referenced this issue Nov 11, 2022
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f
sofisl added a commit that referenced this issue Nov 12, 2022
* fix(filestore): add missing operation_metadata.proto import

PiperOrigin-RevId: 399764091

Source-Link: googleapis/googleapis@5e5a44d

Source-Link: googleapis/googleapis-gen@e0dd43a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTBkZDQzYTUwNTI1NDllNjllOGU3YTI5YzY3ZWZkM2E0Zjg4YTBkZiJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 12, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### [1.1.1](https://www.github.com/googleapis/nodejs-filestore/compare/v1.1.0...v1.1.1) (2021-10-14)


### Bug Fixes

* **filestore:** add missing operation_metadata.proto import ([#24](https://www.github.com/googleapis/nodejs-filestore/issues/24)) ([58f6bd0](https://www.github.com/googleapis/nodejs-filestore/commit/58f6bd08080f79e8b60967f27990783660b0f1be))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Nov 30, 2022
sofisl pushed a commit that referenced this issue Dec 21, 2022
Source-Link: googleapis/synthtool@d229a12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e
sofisl pushed a commit that referenced this issue Jan 10, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: googleapis/googleapis-gen@f16a1d2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9

feat: accept google-gax instance as a parameter
Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: googleapis/googleapis-gen@e97a1ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9
sofisl pushed a commit that referenced this issue Jan 10, 2023
🤖 I have created a release *beep* *boop*
---


## [0.2.3](googleapis/nodejs-run@v0.2.2...v0.2.3) (2022-09-14)


### Bug Fixes

* Allow passing gax instance to client constructor ([#24](googleapis/nodejs-run#24)) ([91e2ac5](googleapis/nodejs-run@91e2ac5))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-run/issues/1553)) ([#23](googleapis/nodejs-run#23)) ([acda49f](googleapis/nodejs-run@acda49f))
* Preserve default values in x-goog-request-params header ([#26](googleapis/nodejs-run#26)) ([debc1eb](googleapis/nodejs-run@debc1eb))
* use google-gax v3.3.0 ([acda49f](googleapis/nodejs-run@acda49f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Jan 17, 2023
* regenerating GAPIC v1 code

* bump version and regenerate scaffolding
sofisl pushed a commit that referenced this issue Jan 26, 2023
Use gapic-generator-typescript v1.2.8.
Committer: @alexander-fenster
PiperOrigin-RevId: 345712055

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Dec 4 10:54:47 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 16dd59787d6ce130ab66066c02eeea9dac0c8f0e
Source-Link: googleapis/googleapis@16dd597
sofisl pushed a commit that referenced this issue Sep 14, 2023
* chore: removing node7 job from CircleCI

* chore: rename reference
sofisl pushed a commit that referenced this issue Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants