Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix: allow passing gax instance to client constructor #24

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Aug 26, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f16a1d224f00a630ea43d6a9a1a31f566f45cdea
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9

feat: accept google-gax instance as a parameter
Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e97a1ac204ead4fe7341f91e72db7c6ac6016341
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: googleapis/googleapis-gen@e97a1ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 26, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: run Issues related to the googleapis/nodejs-run API. labels Aug 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@snippet-bot
Copy link

snippet-bot bot commented Aug 26, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Aug 26, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2022
PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: googleapis/googleapis-gen@f16a1d2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: accept google-gax instance as a parameter fix: use _gaxModule when accessing gax for bundling Aug 30, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Aug 30, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Aug 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2022
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Sep 1, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@alexander-fenster alexander-fenster changed the title fix: use _gaxModule when accessing gax for bundling fix: allow passing gax instance to client constructor Sep 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 91e2ac5 into main Sep 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch September 1, 2022 20:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 1, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 26, 2022
🤖 I have created a release *beep* *boop*
---


## [0.2.3](v0.2.2...v0.2.3) (2022-09-14)


### Bug Fixes

* Allow passing gax instance to client constructor ([#24](#24)) ([91e2ac5](91e2ac5))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-run/issues/1553)) ([#23](#23)) ([acda49f](acda49f))
* Preserve default values in x-goog-request-params header ([#26](#26)) ([debc1eb](debc1eb))
* use google-gax v3.3.0 ([acda49f](acda49f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Jan 10, 2023
🤖 I have created a release *beep* *boop*
---


## [0.2.3](googleapis/nodejs-run@v0.2.2...v0.2.3) (2022-09-14)


### Bug Fixes

* Allow passing gax instance to client constructor ([#24](googleapis/nodejs-run#24)) ([91e2ac5](googleapis/nodejs-run@91e2ac5))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-run/issues/1553)) ([#23](googleapis/nodejs-run#23)) ([acda49f](googleapis/nodejs-run@acda49f))
* Preserve default values in x-goog-request-params header ([#26](googleapis/nodejs-run#26)) ([debc1eb](googleapis/nodejs-run@debc1eb))
* use google-gax v3.3.0 ([acda49f](googleapis/nodejs-run@acda49f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: run Issues related to the googleapis/nodejs-run API. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants