Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README Fix #243

Closed
rominirani opened this issue Sep 25, 2014 · 1 comment
Closed

README Fix #243

rominirani opened this issue Sep 25, 2014 · 1 comment
Assignees
@stephenplusplus
Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Core Stable

Comments

@rominirani
Copy link

The README file contains incorrect function calls:

  1. new datastore.Dataset ... should read new datastore.dataset
  2. new storage.Bucket ... should read new storage.bucket
@stephenplusplus stephenplusplus self-assigned this Sep 25, 2014
@stephenplusplus
Copy link
Contributor

Thanks for catching this!

@jgeewax jgeewax added docs type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 2, 2015
@jgeewax jgeewax added this to the Core Stable milestone Feb 2, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
@sofisl sofisl mentioned this issue Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 16, 2022
@release-please @bcoe
chore: release 1.3.1 (#243)
0ba8ce7
sofisl pushed a commit that referenced this issue Sep 27, 2022
@yoshi-automation @JustinBeckwith
refactor: drop dependency on lodash.merge and update links (#243)
89b3710
@sofisl sofisl mentioned this issue Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 5, 2022
@release-please @bcoe
chore: release 1.3.1 (#243)
529de28
@sofisl sofisl mentioned this issue Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 5, 2022
@release-please @bcoe
chore: release 1.3.1 (#243)
4f8f8b8
@sofisl sofisl mentioned this issue Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 8, 2022
@release-please @bcoe
chore: release 1.3.1 (#243)
03c459b
This was referenced Oct 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Oct 11, 2022
@bcoe @callmehiphop
build: add new kokoro config for coverage and release-please (#243)
0406f99
sofisl pushed a commit that referenced this issue Oct 12, 2022
@bcoe
test: add test for x-goog-api-client (#243)
36b6598
@sofisl sofisl mentioned this issue Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 13, 2022
@release-please
chore(main): release 5.0.2 (#243)
fb621ee 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 13, 2022
@bcoe @sofisl
build: add new kokoro config for coverage and release-please (#243)
b2bc987
sofisl pushed a commit that referenced this issue Nov 9, 2022
@yoshi-automation @JustinBeckwith
refactor: drop dependency on lodash.merge and update links (#243)
bb136d3
This was referenced Nov 9, 2022
Closed
Merged
sofisl pushed a commit that referenced this issue Nov 10, 2022
@renovate @yoshi-automation
chore(deps): update dependency nyc to v14
a63480f 
chore(deps): update dependency nyc to v14

This PR contains the following updates:

| Package | Type | Update | Change | References |
|---|---|---|---|---|
| nyc | devDependencies | major | [`^13.3.0` -> `^14.0.0`](https://diff.intrinsic.com/nyc/13.3.0/14.0.0) | [source](https://togithub.com/istanbuljs/nyc) |

---

### Release Notes

<details>
<summary>istanbuljs/nyc</summary>

### [`v14.0.0`](https://togithub.com/istanbuljs/nyc/blob/master/CHANGELOG.md#&#8203;1400httpsgithubcomistanbuljsnyccomparev1330v1400-2019-04-15)

[Compare Source](https://togithub.com/istanbuljs/nyc/compare/v13.3.0...v14.0.0)

##### Bug Fixes

-   Add `cwd` option to instrument command ([#&#8203;1024](https://togithub.com/istanbuljs/nyc/issues/1024)) ([051d95a](https://togithub.com/istanbuljs/nyc/commit/051d95a))
-   Add config values to hash salt ([#&#8203;988](https://togithub.com/istanbuljs/nyc/issues/988)) ([7ac325d](https://togithub.com/istanbuljs/nyc/commit/7ac325d)), closes [#&#8203;522](https://togithub.com/istanbuljs/nyc/issues/522)
-   Exclude negated not working with '--all' switch ([#&#8203;977](https://togithub.com/istanbuljs/nyc/issues/977)) ([91de23c](https://togithub.com/istanbuljs/nyc/commit/91de23c))
-   Make --all work for transpiled code ([#&#8203;1047](https://togithub.com/istanbuljs/nyc/issues/1047)) ([18e04ba](https://togithub.com/istanbuljs/nyc/commit/18e04ba))
-   Resolve absolute paths in nyc instrument ([#&#8203;1012](https://togithub.com/istanbuljs/nyc/issues/1012)) ([3cb1861](https://togithub.com/istanbuljs/nyc/commit/3cb1861)), closes [#&#8203;1014](https://togithub.com/istanbuljs/nyc/issues/1014)
-   Set processinfo pid/ppid to actual numbers ([#&#8203;1057](https://togithub.com/istanbuljs/nyc/issues/1057)) ([32f75b0](https://togithub.com/istanbuljs/nyc/commit/32f75b0))
-   Use a single instance of nyc for all actions of main command. ([#&#8203;1059](https://togithub.com/istanbuljs/nyc/issues/1059)) ([b909575](https://togithub.com/istanbuljs/nyc/commit/b909575))

##### Features

-   Add `delete` option to instrument command ([#&#8203;1005](https://togithub.com/istanbuljs/nyc/issues/1005)) ([d6db551](https://togithub.com/istanbuljs/nyc/commit/d6db551))
-   Add `include` and `exclude` options to instrument command ([#&#8203;1007](https://togithub.com/istanbuljs/nyc/issues/1007)) ([8da097e](https://togithub.com/istanbuljs/nyc/commit/8da097e))
-   Add processinfo index, add externalId ([#&#8203;1055](https://togithub.com/istanbuljs/nyc/issues/1055)) ([8dcf180](https://togithub.com/istanbuljs/nyc/commit/8dcf180))
-   Add support for nyc.config.js ([#&#8203;1019](https://togithub.com/istanbuljs/nyc/issues/1019)) ([3b203c7](https://togithub.com/istanbuljs/nyc/commit/3b203c7))
-   Add support to exclude files on coverage report generation ([#&#8203;982](https://togithub.com/istanbuljs/nyc/issues/982)) ([509c6aa](https://togithub.com/istanbuljs/nyc/commit/509c6aa))
-   Add test-exclude args to check-coverage and report subcommands. ([0fc217e](https://togithub.com/istanbuljs/nyc/commit/0fc217e))
-   Always build the processinfo temp dir ([#&#8203;1061](https://togithub.com/istanbuljs/nyc/issues/1061)) ([c213469](https://togithub.com/istanbuljs/nyc/commit/c213469))
-   Enable `es-modules` option for nyc instrument command ([#&#8203;1006](https://togithub.com/istanbuljs/nyc/issues/1006)) ([596b120](https://togithub.com/istanbuljs/nyc/commit/596b120))
-   Fix excludeAfterRemap functionality. ([36bcc0b](https://togithub.com/istanbuljs/nyc/commit/36bcc0b))
-   Implement `nyc instrument --complete-copy` ([#&#8203;1056](https://togithub.com/istanbuljs/nyc/issues/1056)) ([2eb13c6](https://togithub.com/istanbuljs/nyc/commit/2eb13c6))
-   Remove bundling ([#&#8203;1017](https://togithub.com/istanbuljs/nyc/issues/1017)) ([b25492a](https://togithub.com/istanbuljs/nyc/commit/b25492a))
-   Support turning off node_modules default exclude via `exclude-node-modules` option ([#&#8203;912](https://togithub.com/istanbuljs/nyc/issues/912)) ([b7e16cd](https://togithub.com/istanbuljs/nyc/commit/b7e16cd))
-   Add support for `--exclude-node-modules` to subcommands. ([#&#8203;1053](https://togithub.com/istanbuljs/nyc/issues/1053)) ([e597c46](https://togithub.com/istanbuljs/nyc/commit/e597c46))

##### BREAKING CHANGES

-   The `--exclude-after-remap` option is now functional and enabled by default.  This causes the `include` and `exclude` lists to be processed after using source maps to determine the original filename of sources.
-   Add a file named 'index.json' to the .nyc_output/processinfo directory, which has a different format from the other files in this dir.
-   Change the data type of the pid/ppid fields in processinfo files
-   `nyc instrument` now honors `include` and `exclude` settings, potentially resulting in some files that were previously instrumented being ignored.
-   The `plugins` option has been renamed to `parser-plugins`.
-   The logic involving include/exclude processing has changed.  Results should be verified to ensure all desired sources have coverage data.
-   `nyc instrument` now enables the `--es-module` option by default.  This can cause failures to instrument scripts which violate `'use strict'` rules.

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`".

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-translate).

#243 automerged by dpebot
@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@jkwlui @JustinBeckwith
build: add Kokoro configs for autorelease (#243)
bf6c577 
* build: add Kokoro configs for autorelease

* build: add Kokoro configs for autorelease

* chore: remove CircleCI config
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@renovate-bot
chore(deps): update dependency ts-loader to v7 (#243)
8416c23 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-loader](https://togithub.com/TypeStrong/ts-loader) | devDependencies | major | [`^6.2.1` -> `^7.0.0`](https://renovatebot.com/diffs/npm/ts-loader/6.2.2/7.0.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-loader</summary>

### [`v7.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v700)

[Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v6.2.2...v7.0.0)

-   [Project reference support enhancements](https://togithub.com/TypeStrong/ts-loader/pull/1076) - thanks [@&#8203;sheetalkamat](https://togithub.com/sheetalkamat)!
-   Following the end of life of Node 8, `ts-loader` no longer supports Node 8 **BREAKING CHANGE**

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-scheduler).
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#243)
c4c5ef6 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 2.2.0 (#243)
4be4aba 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.2.0](https://www.github.com/googleapis/nodejs-datalabeling/compare/v2.1.2...v2.2.0) (2021-01-09)


### Features

* introduces style enumeration ([#242](https://www.github.com/googleapis/nodejs-datalabeling/issues/242)) ([34bd1ec](https://www.github.com/googleapis/nodejs-datalabeling/commit/34bd1ec34d76976cbb96ee75892a62500dbd3cef))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@yoshi-automation
chore: move gitattributes files to node templates (#243)
c0f844b 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/d43b90cc-a087-4c57-864c-1e4f93292dc6/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@3a00b7f
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please @gcf-owl-bot
chore(main): release 4.0.2 (#243)
d769393 
* chore(main): release 4.0.2

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
fix: better support for fallback mode (#243)
978effa 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@bcoe
fix(deps): google-gax v2.17.1 (#243)
a4e414a
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 3.0.1 (#244)
f04b661 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.0.1](https://www.github.com/googleapis/nodejs-document-ai/compare/v3.0.0...v3.0.1) (2021-07-21)


### Bug Fixes

* **deps:** google-gax v2.17.1 ([#243](https://www.github.com/googleapis/nodejs-document-ai/issues/243)) ([a9e4efd](https://www.github.com/googleapis/nodejs-document-ai/commit/a9e4efd2478def845376a951c40b76e3384a8b29))
* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#245](https://www.github.com/googleapis/nodejs-document-ai/issues/245)) ([06bf319](https://www.github.com/googleapis/nodejs-document-ai/commit/06bf3190cad3c9ce98e13aff718bb11db85dd4e5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@bcoe
feat!: moves v4 API to default (#243)
882fa32 
This moves the default API for @google-cloud/talent to v4. v4 does include some breaking changes from v4beta1, a migration guide is being provided to users.
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: update v2.12.0 gapic-generator-typescript (#243)
c3e3ece 
- [ ] Regenerate this pull request now.

Committer: @summer-ji-eng
PiperOrigin-RevId: 424244721

Source-Link: googleapis/googleapis@4b6b01f

Source-Link: googleapis/googleapis-gen@8ac83fb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
build(node): switch back to keystore for publication (#1328) (#243)
ebfd704
@sofisl sofisl mentioned this issue Nov 30, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 30, 2022
@yoshi-automation
chore: regenerate common templates (#243)
4e82a45 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/addf93bb-0c57-4d1f-8f4e-08eaba7ddb1c/targets

- [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Source-Link: googleapis/synthtool@c6706ee
Source-Link: googleapis/synthtool@b33b0e2
Source-Link: googleapis/synthtool@898b38a
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@yoshi-automation @JustinBeckwith
feat: add support for triggers and matching types (#243)
957d095
sofisl added a commit that referenced this issue Jan 26, 2023
@aribray @gcf-owl-bot @sofisl
fix: remove duplicate sample (#243)
33940f4 
* fix: remove duplicate sample

Change-Id: Ia2ab7505eb0f67ec9cc09e9005fb4fb4c284a6c5

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
@sofisl sofisl mentioned this issue Jan 26, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Sep 14, 2023
@bcoe @JustinBeckwith
update to .nycrc with --all enabled (#243)
0dbdbaa
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Core Stable
Development

No branches or pull requests
4 participants
@jgeewax @stephenplusplus @rominirani @yoshi-automation