Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub.subscribe doesn't pass on options properly #949

Closed
mpj opened this issue Nov 17, 2015 · 4 comments
Closed

pubsub.subscribe doesn't pass on options properly #949

mpj opened this issue Nov 17, 2015 · 4 comments
Assignees
@yoshi-automation
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@mpj
Copy link

mpj commented Nov 17, 2015

Looking at the implementation of pubsub.subscribe, it seems like it doesn't pass on any options except ackDeadlineSeconds in the request.
https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/pubsub/index.js#L413

This also means that I cannot specify an pushEndpoint in the subscription.
@stephenplusplus
Copy link
Contributor

Hmm, yes. Good catch, thank you! I'll try to get this fixed and released today.

@stephenplusplus stephenplusplus added the api: pubsub Issues related to the Pub/Sub API. label Nov 17, 2015
@stephenplusplus stephenplusplus mentioned this issue Nov 17, 2015
Merged
@stephenplusplus
Copy link
Contributor

Released! https://github.com/GoogleCloudPlatform/gcloud-node/releases/tag/v0.25.0

@mpj
Copy link
Author

mpj commented Nov 18, 2015

HOLY TURNROUND TIME BATMAN

@stephenplusplus
Copy link
Contributor

@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@renovate-bot
chore(deps): update dependency @types/mocha to v9 (#949)
33077ce 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dialogflow).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpj @stephenplusplus @yoshi-automation