-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pubsub: allow aborting an active HTTP request + auto-abort when subsc… #1105
Conversation
return { | ||
abort: function() { | ||
if (activeRequest_) { | ||
activeRequest_.abort(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
9a520fc
to
d1faf9c
Compare
makeAuthenticatedRequest(reqOpts, assert.ifError).abort(); | ||
}); | ||
|
||
it.only('should only abort() once', function(done) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
d1faf9c
to
920f865
Compare
pubsub: allow aborting an active HTTP request + auto-abort when subsc…
This restores the fix from googleapis#1105 which was broken after googleapis#1070
This restores the fix from googleapis#1105 which was broken after googleapis#1070
…ription closed
RE: #1104
This modifies our core request functionality to expose an
abort
function which cancels an active HTTP request (viarequest
).