datastore: support deferred results. fixes #77. #133

stephenplusplus · 2014-08-23T01:34:00Z

I thought I'd take a stab at #77. If a response from a dataset.get comes back with deferred keys, this will recursively call .get again, only executing the callback passed to the initial .get once, after having gathered all possible results.

lib/datastore/transaction.js

-    var response = entity.formatArray(resp.found);
-    callback(null, isMultipleRequest ? response : response[0]);
-  });
+    var found = entity.formatArray(resp.found);


stephenplusplus · 2014-08-27T18:31:00Z

@rakyll Rebased, should be good to merge 👍

datastore: support deferred results. fixes #77.

rakyll · 2014-08-27T18:45:24Z

Great, thanks!

…or (#133) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2b12f6c9-10d8-4a5e-b86e-af5827858559/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@ba9918c

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1400) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://togithub.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-iam-credentials).

@summer-ji-eng

* chore: update v2.14.2 gapic-generator-typescript Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9943226b-8e9b-44fd-b025-446fc572242a/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@363fe30

🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.3](https://www.github.com/googleapis/nodejs-analytics-admin/compare/v3.0.2...v3.0.3) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#133](https://www.github.com/googleapis/nodejs-analytics-admin/issues/133)) ([ad5ad4d](https://www.github.com/googleapis/nodejs-analytics-admin/commit/ad5ad4da8348f36364cb1f67751bee70161d6c61)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* build: fix broken links PiperOrigin-RevId: 443188324 Source-Link: googleapis/googleapis@775267e Source-Link: googleapis/googleapis-gen@166b6e3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTY2YjZlM2FjNDZlMjgyMWIyYmM5Y2E0NDNjM2FjYTRkMWNiZTc4MiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: fix remaining broken links PiperOrigin-RevId: 443508623 Source-Link: googleapis/googleapis@fd6935f Source-Link: googleapis/googleapis-gen@4f659e3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY2NTllM2I4YWNlMmU4NmMwMjdjNGZlY2E5ZGVjZDZlZTU4YzY0YyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1400) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://togithub.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-appengine-admin).

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…e in region tag (#133) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 399287285 Source-Link: googleapis/googleapis@1575986 Source-Link: googleapis/googleapis-gen@b27fff6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjI3ZmZmNjIzYTVkOGQ1ODZiNzAzYjVlNDkxOTg1NmFiZTdjMmViMyJ9

* betaPR * Fixed Region Tags, automl up next * fixed linting * really actually fixed linting * linter again * Update .eslintignore * update eslintignore again * more linting * really hate linting * Update .eslintrc.yml * That was harsh, lintings okay * Update detect.v1p3beta1.js * Update detect.v1p3beta1.js * Fixed Region Tags * Updated v1p3beta1.js * Fixed detect.v1p3beta1 * Fixed test * removed comment * removed comment * Updated URI paths I'm sorry, I'm having some issues with git here- my branch has had changes from last comments/edits, I'm sorry about redundancies * changed to LLC * Changing google LLC * disable prettier for lint * fixed //standard endpoint * Creates a client fix * removed JSON stringify * changed order * added language hinting also fixed default handwritingGCSuri * forgot fs. * cleaned up spacing between api call and request * cleaned up image examples

chore(deps): update dependency mocha to v6 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | mocha | devDependencies | major | `^5.2.0` -> `^6.0.0` | [homepage](https://mochajs.org/), [source](https://togithub.com/mochajs/mocha) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v6.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#600--2019-02-18) [Compare Source](https://togithub.com/mochajs/mocha/compare/v5.2.0...v6.0.0) #### 🎉 Enhancements - [#3726](https://togithub.com/mochajs/mocha/issues/3726): Add ability to unload files from `require` cache ([**@plroebuck**](https://togithub.com/plroebuck)) #### 🐛 Fixes - [#3737](https://togithub.com/mochajs/mocha/issues/3737): Fix falsy values from options globals ([**@plroebuck**](https://togithub.com/plroebuck)) - [#3707](https://togithub.com/mochajs/mocha/issues/3707): Fix encapsulation issues for `Suite#_onlyTests` and `Suite#_onlySuites` ([**@vkarpov15**](https://togithub.com/vkarpov15)) - [#3711](https://togithub.com/mochajs/mocha/issues/3711): Fix diagnostic messages dealing with plurality and markup of output ([**@plroebuck**](https://togithub.com/plroebuck)) - [#3723](https://togithub.com/mochajs/mocha/issues/3723): Fix "reporter-option" to allow comma-separated options ([**@boneskull**](https://togithub.com/boneskull)) - [#3722](https://togithub.com/mochajs/mocha/issues/3722): Fix code quality and performance of `lookupFiles` and `files` ([**@plroebuck**](https://togithub.com/plroebuck)) - [#3650](https://togithub.com/mochajs/mocha/issues/3650), [#3654](https://togithub.com/mochajs/mocha/issues/3654): Fix noisy error message when no files found ([**@craigtaub**](https://togithub.com/craigtaub)) - [#3632](https://togithub.com/mochajs/mocha/issues/3632): Tests having an empty title are no longer confused with the "root" suite ([**@juergba**](https://togithub.com/juergba)) - [#3666](https://togithub.com/mochajs/mocha/issues/3666): Fix missing error codes ([**@vkarpov15**](https://togithub.com/vkarpov15)) - [#3684](https://togithub.com/mochajs/mocha/issues/3684): Fix exiting problem in Node.js v11.7.0+ ([**@addaleax**](https://togithub.com/addaleax)) - [#3691](https://togithub.com/mochajs/mocha/issues/3691): Fix `--delay` (and other boolean options) not working in all cases ([**@boneskull**](https://togithub.com/boneskull)) - [#3692](https://togithub.com/mochajs/mocha/issues/3692): Fix invalid command-line argument usage not causing actual errors ([**@boneskull**](https://togithub.com/boneskull)) - [#3698](https://togithub.com/mochajs/mocha/issues/3698), [#3699](https://togithub.com/mochajs/mocha/issues/3699): Fix debug-related Node.js options not working in all cases ([**@boneskull**](https://togithub.com/boneskull)) - [#3700](https://togithub.com/mochajs/mocha/issues/3700): Growl notifications now show the correct number of tests run ([**@outsideris**](https://togithub.com/outsideris)) - [#3686](https://togithub.com/mochajs/mocha/issues/3686): Avoid potential ReDoS when diffing large objects ([**@cyjake**](https://togithub.com/cyjake)) - [#3715](https://togithub.com/mochajs/mocha/issues/3715): Fix incorrect order of emitted events when used programmatically ([**@boneskull**](https://togithub.com/boneskull)) - [#3706](https://togithub.com/mochajs/mocha/issues/3706): Fix regression wherein `--reporter-option`/`--reporter-options` did not support comma-separated key/value pairs ([**@boneskull**](https://togithub.com/boneskull)) #### 📖 Documentation - [#3652](https://togithub.com/mochajs/mocha/issues/3652): Switch from Jekyll to Eleventy ([**@Munter**](https://togithub.com/Munter)) #### 🔩 Other - [#3677](https://togithub.com/mochajs/mocha/issues/3677): Add error objects for createUnsupportedError and createInvalidExceptionError ([**@boneskull**](https://togithub.com/boneskull)) - [#3733](https://togithub.com/mochajs/mocha/issues/3733): Removed unnecessary processing in post-processing hook ([**@wanseob**](https://togithub.com/wanseob)) - [#3730](https://togithub.com/mochajs/mocha/issues/3730): Update nyc to latest version ([**@coreyfarrell**](https://togithub.com/coreyfarrell)) - [#3648](https://togithub.com/mochajs/mocha/issues/3648), [#3680](https://togithub.com/mochajs/mocha/issues/3680): Fixes to support latest versions of [unexpected](https://npm.im/unexpected) and [unexpected-sinon](https://npm.im/unexpected-sinon) ([**@sunesimonsen**](https://togithub.com/sunesimonsen)) - [#3638](https://togithub.com/mochajs/mocha/issues/3638): Add meta tag to site ([**@MartijnCuppens**](https://togithub.com/MartijnCuppens)) - [#3653](https://togithub.com/mochajs/mocha/issues/3653): Fix parts of test suite failing to run on Windows ([**@boneskull**](https://togithub.com/boneskull)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-automl). #133 automerged by dpebot

stephenplusplus mentioned this pull request Aug 23, 2014

datastore: Support LookupResponse deferred field #77

Closed

rakyll reviewed Aug 25, 2014
View reviewed changes

datastore: support deferred results. fixes googleapis#77.

473f55d

stephenplusplus force-pushed the deferred branch from ceb8122 to 473f55d Compare August 27, 2014 18:30

rakyll pushed a commit that referenced this pull request Aug 27, 2014

Merge pull request #133 from stephenplusplus/deferred

72752dd

datastore: support deferred results. fixes #77.

rakyll merged commit 72752dd into googleapis:master Aug 27, 2014

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

fix(deps): update dependency google-gax to ^0.23.0 (#133)

f4dd1d8

sofisl pushed a commit that referenced this pull request Oct 5, 2022

fix(deps): update dependency google-gax to ^0.23.0 (#133)

fd6b81e

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

fix(deps): update dependency google-gax to ^0.23.0 (#133)

49b7faa

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: update eslintignore config (#133)

d95214e

This was referenced Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

sofisl pushed a commit that referenced this pull request Oct 13, 2022

fix: remove eslint, update gax, fix generated protos, run the generat…

12552d3

…or (#133) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-monitoring-dashboards #3408

Merged

4 tasks

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

refactor(samples): convert sample tests from ava to mocha (#133)

55cd3f2

sofisl pushed a commit that referenced this pull request Nov 10, 2022

docs: update readme badges (#133)

8924e32

This was referenced Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency sinon to v7 (#133)

53a0eee

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs: document version support goals (#133)

a49c157

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-web-risk #3549

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

test: modernize mocha config (#133)

3a643f4

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-binary-authorization #3576

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-channel #3577

Merged

migrate code from googleapis/nodejs-iam-credentials #3578

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-domains #3581

Merged

migrate code from googleapis/nodejs-bigquery-storage #3599

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-analytics-admin #3600

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): google-gax v2.17.1 (#133)

90000c1

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-appengine-admin #3607

Merged

migrate code from googleapis/nodejs-service-management #3608

Merged

release-please bot mentioned this pull request Nov 12, 2022

chore: release main #3529

Merged

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-managed-identities #3642

Merged

4 tasks

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

sofisl pushed a commit that referenced this pull request Nov 17, 2022

test: use strictEqual in tests (#133)

4686440

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

fix(types): Consolidate "createChange" wrappers, add overloads (#133)

5314153

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore: support deferred results. fixes #77. #133

datastore: support deferred results. fixes #77. #133

stephenplusplus commented Aug 23, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Aug 27, 2014

rakyll commented Aug 27, 2014

datastore: support deferred results. fixes #77. #133

datastore: support deferred results. fixes #77. #133

Conversation

stephenplusplus commented Aug 23, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Aug 27, 2014

rakyll commented Aug 27, 2014