storage: support rewrite operation #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Yes, it is always safe to send Copy requests to the Rewrite API endpoint. It will always handle cross-location, cross-storage class requests, whereas Copy may time out. |
|
Cool, thanks! |
stephenplusplus
force-pushed
the
spp--1373
branch
from
8a03c01
to
ab4fb84
Compare
callmehiphop
reviewed
Oct 5, 2016
| @@ -269,6 +269,12 @@ function File(bucket, name, options) { | |||
|
|
|||
| util.inherits(File, common.ServiceObject); | |||
|
|
|||
| /*! Developer Documentation | |||
| * | |||
| * @param {object=} options - Configuration object. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1373
Compare https://cloud.google.com/storage/docs/json_api/v1/objects/copy and https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite. It sounds like
rewriteis basicallycopy, except with some added capabilities. I kept our method namedcopy, but we only userewritein this PR. LMKWYT.