Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: fix stream destroy bug #2358

Merged
merged 1 commit into from
Jun 5, 2017
Merged

spanner: fix stream destroy bug #2358

merged 1 commit into from
Jun 5, 2017

Conversation

callmehiphop
Copy link
Contributor

Relates to #2356

@callmehiphop callmehiphop added api: spanner Issues related to the Spanner API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 5, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.988% when pulling 8469a50 on callmehiphop:dg--spanner-stream-destroy into 925e651 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 03c276d into googleapis:master Jun 5, 2017
@Chipintoza
Copy link

I update transaction.js
it looks request stream also doesn't have end()

noStatus - TypeError: this.stream.end is not a function
at StreamProxy._onFinish (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/google-gax/lib/streaming.js:103:17)
at StreamProxy. (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/google-gax/lib/streaming.js:76:10)
at emitNone (events.js:86:13)
at StreamProxy.emit (events.js:185:7)
at finishMaybe (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/readable-stream/lib/_stream_writable.js:504:14)
at endWritable (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/readable-stream/lib/_stream_writable.js:514:3)
at StreamProxy.Writable.end (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/readable-stream/lib/_stream_writable.js:484:41)
at StreamProxy. (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/@google-cloud/spanner/src/transaction.js:374:23)
at emitOne (events.js:96:13)
at StreamProxy.emit (events.js:188:7)

@Chipintoza
Copy link

please look comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants