datastore: mark failed rollbacks as finalized #240

stephenplusplus · 2014-09-23T13:56:39Z

If an error occurs upstream while trying to rollback a
transaction, we can mark the transaction as finalized
regardless. By marking it finalized, we don't then
later make an accidental commit when done is
executed.

Fixes #237

ryanseys · 2014-09-27T16:03:20Z

LGTM.

lib/datastore/transaction.js

@@ -124,11 +124,11 @@ Transaction.prototype.rollback = function(callback) {
  var req = new pb.RollbackRequest({ transaction: this.id });
  var res = pb.RollbackResponse;
  this.makeReq('rollback', req, res, function(err) {
+    that.isFinalized = true;
    if (err) {


If an error occurs upstream while trying to rollback a transaction, we can mark the transaction as `finalized` regardless. By marking it `finalized`, we don't then later make an accidental commit when `done` is executed. Fixes googleapis#237

datastore: mark failed rollbacks as finalized

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

* chore(deps): upgrade gapic-generator-java to 2.4.1 PiperOrigin-RevId: 422607515 Source-Link: googleapis/googleapis@ba2ffd6 Source-Link: googleapis/googleapis-gen@73ba4ad Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzNiYTRhZGQyMzlhNjE5ZGE1NjdmZmJkNGU1NzMwZmRkNmRlMDRkMyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/cacd5a12-e156-415f-94a2-533984f6802a/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@363fe30

…lates (#240) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5e903fff-57bb-4395-bb94-8b4d1909dbf6/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@21f1470 Source-Link: googleapis/synthtool@388e10f

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-loader](https://togithub.com/TypeStrong/ts-loader) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/ts-loader/8.1.0/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/compatibility-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/confidence-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v9.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v900) [Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v8.1.0...v9.0.0) Breaking changes: - minimum webpack version: 5 - minimum node version: 12 Changes: - [webpack 5 migration](https://togithub.com/TypeStrong/ts-loader/pull/1251) - thanks [@johnnyreilly](https://togithub.com/johnnyreilly), [@jonwallsten](https://togithub.com/jonwallsten), [@sokra](https://togithub.com/sokra), [@appzuka](https://togithub.com/appzuka), [@alexander-akait](https://togithub.com/alexander-akait) </details> --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-secret-manager).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468735472 Source-Link: googleapis/googleapis@cfa1b37 Source-Link: googleapis/googleapis-gen@09b7666 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

stephenplusplus added the in progress label Sep 23, 2014

stephenplusplus force-pushed the spp--finalize-rollbacks branch from da2eaf9 to 56efd43 Compare September 23, 2014 13:57

stephenplusplus added ready for review and removed in progress labels Sep 23, 2014

stephenplusplus force-pushed the spp--finalize-rollbacks branch from 56efd43 to fd861f7 Compare September 23, 2014 14:02

ryanseys reviewed Sep 27, 2014
View reviewed changes

stephenplusplus force-pushed the spp--finalize-rollbacks branch from fd861f7 to 6defb3a Compare September 27, 2014 16:09

stephenplusplus pushed a commit that referenced this pull request Sep 30, 2014

Merge pull request #240 from stephenplusplus/spp--finalize-rollbacks

ec76344

datastore: mark failed rollbacks as finalized

stephenplusplus merged commit ec76344 into googleapis:master Sep 30, 2014

stephenplusplus removed the ready for review label Sep 30, 2014

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

chore: update nyc config (#240)

589efb0

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore: update CONTRIBUTING.md and make releaseType node (#240)

cd639e0

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: update CONTRIBUTING.md and make releaseType node (#240)

51e4152

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: update CONTRIBUTING.md and make releaseType node (#240)

a884682

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore: update CONTRIBUTING.md and make releaseType node (#240)

8519d27

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-language #3395

Merged

sofisl pushed a commit that referenced this pull request Oct 11, 2022

fix(deps): update dependency google-gax to v1 (#240)

41cb6f3

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: release 1.2.4 (#240)

04c45fa

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

build(owlbot): strip-prefix not supported yet (#240)

afe553d

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-monitoring-dashboards #3408

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore(main): release 5.0.1 (#240)

54d6cc3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl pushed a commit that referenced this pull request Nov 11, 2022

refactor: reformat with latest linter and formatter (#240)

80f1b26

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 2.1.1 (#240)

82f46bc

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-datalabeling #3548

Merged

migrate code from googleapis/nodejs-web-risk #3549

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-containeranalysis #3550

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-secret-manager #3553

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-billing #3556

Merged

migrate code from googleapis/nodejs-service-directory #3557

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: update nyc config (#240)

ce5b3db

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update node.js to v16 (#240)

a1b0886

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

migrate code from googleapis/nodejs-asset #3567

Merged

sofisl pushed a commit that referenced this pull request Nov 17, 2022

fix: modernize the samples (#240)

e586c4a

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

docs: update links in contrib guide (#240)

c393c5f

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

chore: release 1.6.0 (#240)

97725e6

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

fix(deps): update dependency arrify to v2 (#240)

f0b1e7c

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

takeratta mentioned this pull request Dec 14, 2023

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#55

Open

This was referenced Jan 2, 2024

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#58

Open

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#62

Open

takeratta mentioned this pull request Mar 16, 2024

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#65

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore: mark failed rollbacks as finalized #240

datastore: mark failed rollbacks as finalized #240

stephenplusplus commented Sep 23, 2014

ryanseys commented Sep 27, 2014

This comment was marked as spam.

This comment was marked as spam.

datastore: mark failed rollbacks as finalized #240

datastore: mark failed rollbacks as finalized #240

Conversation

stephenplusplus commented Sep 23, 2014

ryanseys commented Sep 27, 2014

This comment was marked as spam.

This comment was marked as spam.