Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Natural Language #2612

Merged
merged 11 commits into from
Sep 18, 2017
Merged

Update Natural Language #2612

merged 11 commits into from
Sep 18, 2017

Conversation

lukesneeringer
Copy link
Contributor

This is an update to the natural language API, both v1 and v1beta2, to add new features. Notably, (e.g. for the release notes), this adds the analyzeEntitySentiment method to v1.

@landrito Please sanity check.
@stephenplusplus Once Ernest has sanity checked, please merge and release to npm, and email me when this is done.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2017
@lukesneeringer
Copy link
Contributor Author

@callmehiphop CI is failing on docs for this (and #2613) and I have no idea why. Could you investigate?


/*!
* @module language
* @name Language

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@landrito landrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity Check LGTM

@lukesneeringer
Copy link
Contributor Author

@stephenplusplus Can you release this to npm?

@stephenplusplus
Copy link
Contributor

Hey, quick thing I noticed-- we use the protos directory in other places in the repo, but the change here uses proto. I tried just moving the files to protos and updating the references in the video_intellience_service_client.js files to match. But I hit an error:

Error: ENOENT: no such file or directory, open 'C:\Users\sawch\dev\GCN\packages\video-intelligence\proto\google\cloud\videointelligence\v1beta2\video_intelligence.proto'
    at Object.fs.openSync (fs.js:652:18)
    at Object.fs.readFileSync (fs.js:553:33)
    at fetch (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\protobufjs\src\root.js:160:34)
    at GoogleProtoFilesRoot.load (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\protobufjs\src\root.js:194:13)
    at GoogleProtoFilesRoot.loadSync (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\protobufjs\src\root.js:235:17)
    at Object.loadSync (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\protobufjs\src\index-light.js:69:17)
    at GrpcClient.loadProto (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\google-gax\lib\grpc.js:156:14)
    at Object.<anonymous> (C:\Users\sawch\dev\GCN\packages\video-intelligence\src\index.js:77:31)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (C:\Users\sawch\dev\GCN\packages\video-intelligence\test\gapic-v1beta1.js:19:25)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)
    at C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\mocha\lib\mocha.js:231:27
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\mocha\lib\mocha.js:228:14)
    at Mocha.run (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\mocha\lib\mocha.js:514:10)
    at Object.<anonymous> (C:\Users\sawch\dev\GCN\packages\video-intelligence\node_modules\mocha\bin\_mocha:480:18)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:598:3

Did I miss a reference, or does this mean something needs to be changed in google-gax?

cc @landrito

@stephenplusplus stephenplusplus added the api: language Issues related to the Cloud Natural Language API API. label Sep 18, 2017
@lukesneeringer lukesneeringer requested a review from a team as a code owner September 18, 2017 21:52
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 18, 2017
@googleapis googleapis deleted a comment from googlebot Sep 18, 2017
@googleapis googleapis deleted a comment from coveralls Sep 18, 2017
@googleapis googleapis deleted a comment from coveralls Sep 18, 2017
@googleapis googleapis deleted a comment from coveralls Sep 18, 2017
@googleapis googleapis deleted a comment from coveralls Sep 18, 2017
@googleapis googleapis deleted a comment from coveralls Sep 18, 2017
@googleapis googleapis deleted a comment from coveralls Sep 18, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c33e531 on nl into 9e78eba on master.

@stephenplusplus stephenplusplus merged commit 641d5a3 into master Sep 18, 2017
sofisl pushed a commit that referenced this pull request Oct 11, 2022
sofisl pushed a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants