fix (regression tests): make datastore queries strongly consistent #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| describe('querying the datastore', function() { | ||
| describe.only('querying the datastore', function() { | ||
|
|
||
| var ancestor = ['Book', 'GoT']; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The previous tests were flaky because based on eventually consistent queries. The new tests use only ancestor queries, that are strongly consistent.
silvolu
force-pushed
the
fix-datastore-regression
branch
from
b057b5b
to
e633edf
Compare
|
Done (squashed to avoid leaving traces of my bad commits :) ) |
|
Perfect! Thanks! Merging. PS: Github knows. 👀 |
|
... will merge after tests run ... |
ryanseys
added a commit
that referenced
this pull request
Oct 23, 2014
fix (regression tests): make datastore queries strongly consistent
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 23, 2014
Integrates changes from googleapis/google-cloud-node#267
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 23, 2014
Integrates changes from googleapis/google-cloud-node#267
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
This was referenced Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* updated CHANGELOG.md * updated package.json * updated samples/package.json
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.1](https://www.github.com/googleapis/nodejs-containeranalysis/compare/v3.0.0...v3.0.1) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#267](https://www.github.com/googleapis/nodejs-containeranalysis/issues/267)) ([003a128](https://www.github.com/googleapis/nodejs-containeranalysis/commit/003a128f84f0a7cdcff34ba77dc60d88a4d7969b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
…quire approval before executing and ApproveBuild API to approve or reject pending Builds (#267) Comitter: @joonlim PiperOrigin-RevId: 391072303 Source-Link: googleapis/googleapis@7fec729 Source-Link: googleapis/googleapis-gen@22f5dc3
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.2...v2.4.0) (2021-08-16) ### Features * Add ability to configure BuildTriggers to create Builds that require approval before executing and ApproveBuild API to approve or reject pending Builds ([#267](https://www.github.com/googleapis/nodejs-cloudbuild/issues/267)) ([18ec067](https://www.github.com/googleapis/nodejs-cloudbuild/commit/18ec067ac1e112836c5d56747dda89e04f87c481)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#​1400) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://togithub.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dialogflow-cx).
](https://renovatebot.com){kind=link}
sofisl
pushed a commit
that referenced
this pull request
Nov 17, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
PiperOrigin-RevId: 429098186 Source-Link: googleapis/googleapis@e75c527 Source-Link: googleapis/googleapis-gen@6114713 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjExNDcxMzMzODE4Zjg4ZjY2YmZlMjRhYzk3ZDIwNjRjZTBiNTJhZCJ9
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
* updated CHANGELOG.md * updated package.json * updated samples/package.json
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous tests were flaky because based on eventually consistent queries.
The new tests use only ancestor queries, that are strongly consistent.