remove bucket env var req. & stop deleting all buckets #275

stephenplusplus · 2014-11-03T16:25:47Z

fixes #270
fixes #271

fixes googleapis#270 fixes googleapis#271

stephenplusplus · 2014-11-03T18:42:21Z

PTAL

regression/storage.js

-      });
+  after(function(done) {
+    deleteFiles(bucket, function(err) {
+      if (err) {


ryanseys · 2014-11-03T21:09:18Z

This looks good to me. @silvolu might like to take a second look, however.

silvolu · 2014-11-04T00:14:49Z

Good to go.

remove bucket env var req. & stop deleting all buckets

🤖 I have created a release \*beep\* \*boop\* --- ## [1.8.0](https://www.github.com/googleapis/nodejs-iot/compare/v1.7.0...v1.8.0) (2020-03-06) ### Features * deferred client initialization ([#283](https://www.github.com/googleapis/nodejs-iot/issues/283)) ([b70a193](https://www.github.com/googleapis/nodejs-iot/commit/b70a1938f4254fff0f3839bca5871207b8d97c35)) * export protos in src/index.ts ([9c3098c](https://www.github.com/googleapis/nodejs-iot/commit/9c3098ca5a232f7fb575d5dce2bc1473365b20bd)) ### Bug Fixes * pass x-goog-request-params header for streaming calls ([5a35e0f](https://www.github.com/googleapis/nodejs-iot/commit/5a35e0fd4ea40a1a5e9be2c03e83db5fb7c11f81)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.8](https://www.github.com/googleapis/nodejs-web-risk/compare/v2.1.7...v2.1.8) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#275](https://www.github.com/googleapis/nodejs-web-risk/issues/275)) ([daa0774](https://www.github.com/googleapis/nodejs-web-risk/commit/daa0774aaa6e6a0c274c894e2bfbd8cfc2726d88)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^11.0.0` -> `^12.0.0`](https://renovatebot.com/diffs/npm/sinon/11.1.2/12.0.1) | [![age](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/compatibility-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/confidence-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v12.0.1`](https://togithub.com/sinonjs/sinon/blob/master/CHANGES.md#1201) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v12.0.0...v12.0.1) - [`3f598221`](https://togithub.com/sinonjs/sinon/commit/3f598221045904681f2b3b3ba1df617ed5e230e3) Fix issue with npm unlink for npm version > 6 (Carl-Erik Kopseng) > 'npm unlink' would implicitly unlink the current dir > until version 7, which requires an argument - [`51417a38`](https://togithub.com/sinonjs/sinon/commit/51417a38111eeeb7cd14338bfb762cc2df487e1b) Fix bundling of cjs module ([#2412](https://togithub.com/sinonjs/sinon/issues/2412)) (Julian Grinblat) > - Fix bundling of cjs module > > - Run prettier *Released by [Carl-Erik Kopseng](https://togithub.com/fatso83) on 2021-11-04.* #### 12.0.0 ### [`v12.0.0`](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-billing-budgets).

🤖 I have created a release \*beep\* \*boop\* --- ### [3.7.3](https://www.github.com/googleapis/nodejs-secret-manager/compare/v3.7.2...v3.7.3) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#273](https://www.github.com/googleapis/nodejs-secret-manager/issues/273)) ([9988608](https://www.github.com/googleapis/nodejs-secret-manager/commit/9988608f48b46485d0f5177f2a2e02e5997528cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.2](https://www.github.com/googleapis/nodejs-talent/compare/v3.0.1...v3.0.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#274](https://www.github.com/googleapis/nodejs-talent/issues/274)) ([a25c71f](https://www.github.com/googleapis/nodejs-talent/commit/a25c71ff62a46138e088f01d5b9cd8b165588bbd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

…rm v1 endpoint.proto (#275) * feat: add PredictRequestResponseLoggingConfig to Endpoint in aiplatform v1 endpoint.proto PiperOrigin-RevId: 433794371 Source-Link: googleapis/googleapis@e0f0642 Source-Link: googleapis/googleapis-gen@3afc3ec Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2FmYzNlYzE4ZTc5NWM4NTkyMzFhMmMwZjhlZjE3MmE2NTA1NmUwZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

stephenplusplus added the in progress label Nov 3, 2014

Stephen Sawchuk added 2 commits November 3, 2014 13:31

remove bucket env var req. & stop deleting all buckets

a049907

fixes googleapis#270 fixes googleapis#271

fix BQ error + retry retry logic

c05aaa1

stephenplusplus force-pushed the spp--fix-storage-tests branch from 7464e17 to c05aaa1 Compare November 3, 2014 18:42

ryanseys reviewed Nov 3, 2014
View reviewed changes

regression/storage.js

});

after(function(done) {

deleteFiles(bucket, function(err) {

if (err) {

This comment was marked as spam.

Sign in to view

make error throwing more concise.

17d8f77

silvolu added a commit that referenced this pull request Nov 4, 2014

Merge pull request #275 from stephenplusplus/spp--fix-storage-tests

d457f72

remove bucket env var req. & stop deleting all buckets

silvolu merged commit d457f72 into googleapis:master Nov 4, 2014

stephenplusplus removed the in progress label Nov 4, 2014

sofisl pushed a commit that referenced this pull request Sep 27, 2022

docs: use the jsdoc-fresh theme (#275)

0a98a4d

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 11, 2022

fix(deps): update dependency @google-cloud/storage to v3 (#275)

c3b25ec

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: regenerate synth.metadata (#275)

4312b8c

This was referenced Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

sofisl pushed a commit that referenced this pull request Oct 13, 2022

build: .OwlBot.lock.yaml was missing deep-remove (#275)

0fa02cd

sofisl pushed a commit that referenced this pull request Oct 13, 2022

fix(deps): update dependency @google-cloud/storage to v3 (#275)

cfc0ade

sofisl pushed a commit that referenced this pull request Nov 9, 2022

docs: use the jsdoc-fresh theme (#275)

f3aeaef

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

sofisl pushed a commit that referenced this pull request Nov 10, 2022

refactor: drop dependency on lodash.merge and update links (#275)

405f248

This was referenced Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

sofisl pushed a commit that referenced this pull request Nov 10, 2022

chore: update pull request template (#275)

63a1d8f

sofisl pushed a commit that referenced this pull request Nov 10, 2022

update .nycrc ignore rules (#275)

39ebf8e

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

build: use config file for linkinator (#275)

72e109c

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dialogflow #3546

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs: update contributing path in README (#275)

e7265e8

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): google-gax v2.24.1 (#275)

4edb7c7

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-web-risk #3549

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-billing-budgets #3552

Merged

migrate code from googleapis/nodejs-secret-manager #3553

Merged

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 2.6.0 (#275)

5fab756

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-talent #3568

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-bigquery-storage #3599

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency @google-cloud/bigquery to v6 (#275)

c1a36c9

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

build: only pipe to codecov if tests run on Node 10 (#275)

93381a8

sofisl pushed a commit that referenced this pull request Jan 24, 2023

fix(deps): update dependency google-gax to ^0.23.0 (#275)

3e5e4df

sofisl pushed a commit that referenced this pull request Jan 25, 2023

fix(deps): update dependency google-gax to ^0.23.0 (#275)

1e6a7a2

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

takeratta mentioned this pull request Jul 6, 2023

[Snyk] Fix for 1 vulnerabilities takeratta/google-cloud-node#3

Open

sofisl pushed a commit that referenced this pull request Sep 14, 2023

build: remove unused clang format (#275)

52f7b08

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

takeratta mentioned this pull request Nov 28, 2023

[Snyk] Fix for 21 vulnerabilities takeratta/google-cloud-node#28

Open

takeratta mentioned this pull request May 13, 2024

[Snyk] Fix for 2 vulnerabilities takeratta/google-cloud-node#70

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove bucket env var req. & stop deleting all buckets #275

remove bucket env var req. & stop deleting all buckets #275

stephenplusplus commented Nov 3, 2014

stephenplusplus commented Nov 3, 2014

This comment was marked as spam.

ryanseys commented Nov 3, 2014

silvolu commented Nov 4, 2014

remove bucket env var req. & stop deleting all buckets #275

remove bucket env var req. & stop deleting all buckets #275

Conversation

stephenplusplus commented Nov 3, 2014

stephenplusplus commented Nov 3, 2014

This comment was marked as spam.

ryanseys commented Nov 3, 2014

silvolu commented Nov 4, 2014