Storage: add move method to File object #529

mziccard · 2015-05-05T15:56:43Z

Just a simple move function for a File object. It uses the already available copy and delete.
I also added some unit tests.

lib/storage/file.js

+  var deleteFunction = File.prototype.delete.bind(this);
+  this.copy(destination, function(err, destinationFile, apiResponse) {
+    if (err) {
+      callback(err, destinationFile, apiResponse);


ryanseys · 2015-05-05T22:32:18Z

I like the idea. And code looks great! Can you squash your commits to get rid of those messy merge commits 😃 thanks!

stephenplusplus · 2015-05-05T22:48:50Z

I like these helpers, too. Thanks!

test/storage/file.js

+      }, /should have a name/);
+    });
+
+    describe('destination types', function() {


mziccard · 2015-05-06T14:18:22Z

I fixed the mess I did with merges and made other corrections. Tests should now be better but please double-check them:)

stephenplusplus · 2015-05-08T14:04:45Z

Awesome, thank you!

Look how happy you made gcloud:

(Those are tears of joy)

Storage: add move method to File object

🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/nodejs-redis/compare/v2.3.1...v2.4.0) (2021-11-10) ### Features * [Cloud Memorystore for Redis] Support Multiple Read Replicas when creating Instance ([#526](https://www.github.com/googleapis/nodejs-redis/issues/526)) ([ea43df2](https://www.github.com/googleapis/nodejs-redis/commit/ea43df28f39b1943f0c9aea97df51252f4cc2a9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.

🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.4](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.2.3...v3.2.4) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#529](https://www.github.com/googleapis/nodejs-text-to-speech/issues/529)) ([5c6c68c](https://www.github.com/googleapis/nodejs-text-to-speech/commit/5c6c68cb54aa684a4d2f33cedc6565ef2f17e153)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@summer-ji-eng

* fix: GoogleAdsError missing using generator version after 1.3.0 [PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343 * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.2](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.1...v2.3.2) (2021-05-25) ### Bug Fixes * GoogleAdsError missing using generator version after 1.3.0 ([#529](https://www.github.com/googleapis/nodejs-tasks/issues/529)) ([760c204](https://www.github.com/googleapis/nodejs-tasks/commit/760c2043f9bccb0d2787e83dd08ace942e6b10fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore(main): release 3.0.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: fetch for default branch Source-Author: Billy Jacobson <billyjacobson@users.noreply.github.com> Source-Date: Thu Apr 15 20:13:42 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: 898b38a6f4fab89a76dfb152480bb034a781331b Source-Link: googleapis/synthtool@898b38a * build(node): remove unused tokens Source-Author: Benjamin E. Coe <bencoe@google.com> Source-Date: Fri Apr 16 10:12:05 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: b33b0e2056a85fc2264b294f2cf47dcd45e95186 Source-Link: googleapis/synthtool@b33b0e2 * fix(node): default-branch should use $default_branch Source-Author: Benjamin E. Coe <bencoe@google.com> Source-Date: Fri Apr 16 10:25:52 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: c6706ee5d693e9ae5967614170732646590d8374 Source-Link: googleapis/synthtool@c6706ee

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

…mplate provided (#530) Fixes #529

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/ba2d388f-b3b2-4ad7-a163-0c6b4d86894f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@05de3e1

🤖 I have created a release *beep* *boop* --- ## [3.0.1](googleapis/nodejs-dns@v3.0.0...v3.0.1) (2022-06-09) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#529](googleapis/nodejs-dns#529)) ([4e8b02f](googleapis/nodejs-dns@4e8b02f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2015

ryanseys reviewed May 5, 2015
View reviewed changes

lib/storage/file.js

var deleteFunction = File.prototype.delete.bind(this);

this.copy(destination, function(err, destinationFile, apiResponse) {

if (err) {

callback(err, destinationFile, apiResponse);

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed May 5, 2015
View reviewed changes

test/storage/file.js

}, /should have a name/);

});

describe('destination types', function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

storage: add move function to File

4a9a1e0

mziccard force-pushed the move-file branch from 80fb4c6 to 4a9a1e0 Compare May 6, 2015 14:13

stephenplusplus closed this May 8, 2015

stephenplusplus reopened this May 8, 2015

stephenplusplus pushed a commit that referenced this pull request May 8, 2015

Merge pull request #529 from mziccard/move-file

a81418a

Storage: add move method to File object

stephenplusplus merged commit a81418a into googleapis:master May 8, 2015

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-language #3395

Merged

sofisl pushed a commit that referenced this pull request Oct 11, 2022

chore: release 4.2.1 (#529)

2a0eec1

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore: release 4.2.1 (#529)

905bd7d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

chore: update npm scripts and synth.py (#529)

eba3f10

Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

fix(deps): google-gax v2.17.0 with mTLS (#529)

85946fa

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-container #3543

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

build: add generated samples to .eslintignore (#529)

28d88a6

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-kms #3601

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 17, 2022

fix(createVM): do not define machineType or networkInterfaces when te…

ae93a1e

…mplate provided (#530) Fixes #529

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

fix(deps): update dependency @google-cloud/common to v4 (#529)

d4c918d

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage: add move method to File object #529

Storage: add move method to File object #529

mziccard commented May 5, 2015

This comment was marked as spam.

ryanseys commented May 5, 2015

stephenplusplus commented May 5, 2015

This comment was marked as spam.

This comment was marked as spam.

mziccard commented May 6, 2015

stephenplusplus commented May 8, 2015

Storage: add move method to File object #529

Storage: add move method to File object #529

Conversation

mziccard commented May 5, 2015

This comment was marked as spam.

ryanseys commented May 5, 2015

stephenplusplus commented May 5, 2015

This comment was marked as spam.

This comment was marked as spam.

mziccard commented May 6, 2015

stephenplusplus commented May 8, 2015