Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: close sockets on error #636

Merged
merged 1 commit into from
Jun 5, 2015
Merged

storage: close sockets on error #636

merged 1 commit into from
Jun 5, 2015

Conversation

stephenplusplus
Copy link
Contributor

Continuing from #530
Fixes #523

  • Tests

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 2, 2015
@stephenplusplus stephenplusplus mentioned this pull request Jun 2, 2015
Closed
@stephenplusplus stephenplusplus force-pushed the spp--storage-close-sockets-on-error branch 2 times, most recently from 670f845 to 96e659f Compare June 2, 2015 17:39
@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 2, 2015
@ryanseys
Copy link
Contributor

ryanseys commented Jun 2, 2015

Why don't merge?

@stephenplusplus
Copy link
Contributor Author

Needs tests!

@stephenplusplus stephenplusplus force-pushed the spp--storage-close-sockets-on-error branch from 96e659f to 3f2e960 Compare June 4, 2015 15:06
@stephenplusplus
Copy link
Contributor Author

@ryanseys tests are ready if you want to take a glance. The feature implementation is the same.

@jgeewax / @robertdimarco this is the last outstanding PR before the next release is ready.

stephenplusplus
stephenplusplus reviewed Jun 4, 2015
View reviewed changes
test/storage/file.js
return FakeFailedRequest;
}

it('should send query.generation if File has one', function(done) {

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus force-pushed the spp--storage-close-sockets-on-error branch from 3f2e960 to aad528a Compare June 4, 2015 15:15
@stephenplusplus
Copy link
Contributor Author

Going to merge since the implementation was reviewed previously.

stephenplusplus pushed a commit that referenced this pull request Jun 5, 2015
Merge pull request #636 from stephenplusplus/spp--storage-close-socke…
8acdc75 
…ts-on-error

storage: close sockets on error
@stephenplusplus stephenplusplus merged commit 8acdc75 into googleapis:master Jun 5, 2015
chingor13 pushed a commit that referenced this pull request Aug 22, 2022
@release-please
chore(main): release 4.1.0 (#636)
8a0fe8f 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Aug 22, 2022
@release-please
chore(main): release 4.1.0 (#636)
3777296 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Aug 22, 2022
@release-please
chore(main): release 4.1.0 (#636)
13f9789 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@parthea
chore: add api_shortname and library_type to repo metadata (#636)
90c918c 
Update .repo-metadata.json as required by go/library-data-integrity
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@parthea @sofisl
chore: add api_shortname and library_type to repo metadata (#636)
3b33fc2 
Update .repo-metadata.json as required by go/library-data-integrity
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot
chore(deps): update dependency linkinator to v4 (#636)
0ebefee 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [linkinator](https://togithub.com/JustinBeckwith/linkinator) | [`^2.0.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/linkinator/2.16.2/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/compatibility-slim/2.16.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/linkinator/4.0.0/confidence-slim/2.16.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>JustinBeckwith/linkinator</summary>

### [`v4.0.0`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v4.0.0)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.1.0...v4.0.0)

##### Features

-   create new release with notes ([#&#8203;508](https://togithub.com/JustinBeckwith/linkinator/issues/508)) ([2cab633](https://togithub.com/JustinBeckwith/linkinator/commit/2cab633c9659eb10794a4bac06f8b0acdc3e2c0c))

##### BREAKING CHANGES

-   The commits in [#&#8203;507](https://togithub.com/JustinBeckwith/linkinator/issues/507) and [#&#8203;506](https://togithub.com/JustinBeckwith/linkinator/issues/506) both had breaking changes.  They included dropping support for Node.js 12.x and updating the CSV export to be streaming, and to use a new way of writing the CSV file.  This is an empty to commit using the `BREAKING CHANGE` format in the commit message to ensure a release is triggered.

### [`v3.1.0`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.1.0)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.6...v3.1.0)

##### Features

-   allow --skip to be defined multiple times ([#&#8203;399](https://togithub.com/JustinBeckwith/linkinator/issues/399)) ([5ca5a46](https://togithub.com/JustinBeckwith/linkinator/commit/5ca5a461508e688de12e5ae6b4cfb6565f832ebf))

### [`v3.0.6`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.6)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.5...v3.0.6)

##### Bug Fixes

-   **deps:** upgrade node-glob to v8 ([#&#8203;397](https://togithub.com/JustinBeckwith/linkinator/issues/397)) ([d334dc6](https://togithub.com/JustinBeckwith/linkinator/commit/d334dc6734cd7c2b73d7ed3dea0550a6c3072ad5))

### [`v3.0.5`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.5)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.4...v3.0.5)

##### Bug Fixes

-   **deps:** upgrade to htmlparser2 v8.0.1 ([#&#8203;396](https://togithub.com/JustinBeckwith/linkinator/issues/396)) ([ba3b9a8](https://togithub.com/JustinBeckwith/linkinator/commit/ba3b9a8a9b19d39af6ed91790135e833b80c1eb6))

### [`v3.0.4`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.4)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.3...v3.0.4)

##### Bug Fixes

-   **deps:** update dependency gaxios to v5 ([#&#8203;391](https://togithub.com/JustinBeckwith/linkinator/issues/391)) ([48af50e](https://togithub.com/JustinBeckwith/linkinator/commit/48af50e787731204aeb7eff41325c62291311e45))

### [`v3.0.3`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.3)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.2...v3.0.3)

##### Bug Fixes

-   export getConfig from index ([#&#8203;371](https://togithub.com/JustinBeckwith/linkinator/issues/371)) ([0bc0355](https://togithub.com/JustinBeckwith/linkinator/commit/0bc0355c7e2ea457f247e6b52d1577b8c4ecb3a1))

### [`v3.0.2`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.2)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.1...v3.0.2)

##### Bug Fixes

-   allow server root with trailing slash ([#&#8203;370](https://togithub.com/JustinBeckwith/linkinator/issues/370)) ([8adf6b0](https://togithub.com/JustinBeckwith/linkinator/commit/8adf6b025fda250e38461f1cdad40fe08c3b3b7c))

### [`v3.0.1`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.1)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v3.0.0...v3.0.1)

##### Bug Fixes

-   decode path parts in local web server ([#&#8203;369](https://togithub.com/JustinBeckwith/linkinator/issues/369)) ([4696a0c](https://togithub.com/JustinBeckwith/linkinator/commit/4696a0c38c341b178ed815f47371fca955979feb))

### [`v3.0.0`](https://togithub.com/JustinBeckwith/linkinator/releases/tag/v3.0.0)

[Compare Source](https://togithub.com/JustinBeckwith/linkinator/compare/v2.16.2...v3.0.0)

##### Bug Fixes

-   **deps:** update dependency chalk to v5 ([#&#8203;362](https://togithub.com/JustinBeckwith/linkinator/issues/362)) ([4b17a8d](https://togithub.com/JustinBeckwith/linkinator/commit/4b17a8d87b649eaf813428f8ee6955e1d21dae4f))

-   feat!: convert to es modules, drop node 10 ([#&#8203;359](https://togithub.com/JustinBeckwith/linkinator/issues/359)) ([efee299](https://togithub.com/JustinBeckwith/linkinator/commit/efee299ab8a805accef751eecf8538915a4e7783)), closes [#&#8203;359](https://togithub.com/JustinBeckwith/linkinator/issues/359)

##### BREAKING CHANGES

-   this module now requires node.js 12 and above, and has moved to es modules by default.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-tasks).
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 4.1.0 (#636)
9bc4bc9 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@yoshi-automation @alexander-fenster
build: use gapic-generator-typescript v1.0.7. (#636)
9dc6325 
This new generator will bring some changes to the generated code across all libraries, but the behavior will only change for nodejs-logging and nodejs-pubsub (those two libraries that use request batching). For other libraries, the changes should be minor (the createApiCall call is simplified) and it should be safe to merge them. Please talk to @alexander-fenster if you have any questions.

PiperOrigin-RevId: 325949033

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Aug 10 21:11:13 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 94006b3cb8d2fb44703cf535da15608eed6bf7db
Source-Link: googleapis/googleapis@94006b3

Co-authored-by: Alexander Fenster <fenster@google.com>
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@yoshi-automation @alexander-fenster
build: use gapic-generator-typescript v1.0.7. (#636)
c09bff9 
This new generator will bring some changes to the generated code across all libraries, but the behavior will only change for nodejs-logging and nodejs-pubsub (those two libraries that use request batching). For other libraries, the changes should be minor (the createApiCall call is simplified) and it should be safe to merge them. Please talk to @alexander-fenster if you have any questions.

PiperOrigin-RevId: 325949033

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Aug 10 21:11:13 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 94006b3cb8d2fb44703cf535da15608eed6bf7db
Source-Link: googleapis/googleapis@94006b3

Co-authored-by: Alexander Fenster <fenster@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connections not cleaned up if disconnected mid-download?
3 participants
@stephenplusplus @ryanseys @googlebot