Skip to content

Commit

Permalink
build: use gapic-generator-typescript v1.0.7. (#636)
Browse files Browse the repository at this point in the history
This new generator will bring some changes to the generated code across all libraries, but the behavior will only change for nodejs-logging and nodejs-pubsub (those two libraries that use request batching). For other libraries, the changes should be minor (the createApiCall call is simplified) and it should be safe to merge them. Please talk to @alexander-fenster if you have any questions.

PiperOrigin-RevId: 325949033

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Aug 10 21:11:13 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 94006b3cb8d2fb44703cf535da15608eed6bf7db
Source-Link: googleapis/googleapis@94006b3

Co-authored-by: Alexander Fenster <fenster@google.com>
  • Loading branch information
yoshi-automation and alexander-fenster authored Sep 1, 2020
1 parent 4baa91e commit 9dc6325
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
8 changes: 5 additions & 3 deletions packages/google-cloud-speech/src/v1/speech_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,14 @@ export class SpeechClient {
}
);

const descriptor =
this.descriptors.stream[methodName] ||
this.descriptors.longrunning[methodName] ||
undefined;
const apiCall = this._gaxModule.createApiCall(
callPromise,
this._defaults[methodName],
this.descriptors.page[methodName] ||
this.descriptors.stream[methodName] ||
this.descriptors.longrunning[methodName]
descriptor
);

this.innerApiCalls[methodName] = apiCall;
Expand Down
8 changes: 5 additions & 3 deletions packages/google-cloud-speech/src/v1p1beta1/speech_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,14 @@ export class SpeechClient {
}
);

const descriptor =
this.descriptors.stream[methodName] ||
this.descriptors.longrunning[methodName] ||
undefined;
const apiCall = this._gaxModule.createApiCall(
callPromise,
this._defaults[methodName],
this.descriptors.page[methodName] ||
this.descriptors.stream[methodName] ||
this.descriptors.longrunning[methodName]
descriptor
);

this.innerApiCalls[methodName] = apiCall;
Expand Down
6 changes: 3 additions & 3 deletions packages/google-cloud-speech/synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-speech.git",
"sha": "eb79211004da4a316d9fe17f451ebdebcb657b7a"
"sha": "59a09abbeb5d695f014839e441e716af9aa364dc"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "4f4aa3a03e470f1390758b9d89eb1aa88837a5be",
"internalRef": "320300472"
"sha": "94006b3cb8d2fb44703cf535da15608eed6bf7db",
"internalRef": "325949033"
}
},
{
Expand Down

0 comments on commit 9dc6325

Please sign in to comment.